Skip to content

Cache evaluation option flags in ExecutionFrameBase #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 25, 2026
Merged

Cache evaluation option flags in ExecutionFrameBase #2293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions eval/eval/evaluator_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,18 @@ class ExecutionFrameBase {
activation.GetMissingAttributes()),
slots_(&ComprehensionSlots::GetEmptyInstance()),
max_iterations_(options.comprehension_max_iterations),
iterations_(0) {
iterations_(0),
attribute_tracking_enabled_(
options_->unknown_processing !=
cel::UnknownProcessingOptions::kDisabled ||
options_->enable_missing_attribute_errors),
missing_attribute_errors_enabled_(
options_->enable_missing_attribute_errors),
unknown_processing_enabled_(options_->unknown_processing !=
cel::UnknownProcessingOptions::kDisabled),
unknown_function_results_enabled_(
options_->unknown_processing ==
cel::UnknownProcessingOptions::kAttributeAndFunction) {
if (unknown_processing_enabled()) {
if (auto matcher = cel::runtime_internal::
ActivationAttributeMatcherAccess::GetAttributeMatcher(activation);
Expand Down Expand Up @@ -209,7 +220,18 @@ class ExecutionFrameBase {
activation.GetMissingAttributes()),
slots_(&slots),
max_iterations_(options.comprehension_max_iterations),
iterations_(0) {
iterations_(0),
attribute_tracking_enabled_(
options_->unknown_processing !=
cel::UnknownProcessingOptions::kDisabled ||
options_->enable_missing_attribute_errors),
missing_attribute_errors_enabled_(
options_->enable_missing_attribute_errors),
unknown_processing_enabled_(options_->unknown_processing !=
cel::UnknownProcessingOptions::kDisabled),
unknown_function_results_enabled_(
options_->unknown_processing ==
cel::UnknownProcessingOptions::kAttributeAndFunction) {
if (unknown_processing_enabled()) {
if (auto matcher = cel::runtime_internal::
ActivationAttributeMatcherAccess::GetAttributeMatcher(activation);
Expand Down Expand Up @@ -246,23 +268,19 @@ class ExecutionFrameBase {
}

bool attribute_tracking_enabled() const {
return options_->unknown_processing !=
cel::UnknownProcessingOptions::kDisabled ||
options_->enable_missing_attribute_errors;
return attribute_tracking_enabled_;
}

bool missing_attribute_errors_enabled() const {
return options_->enable_missing_attribute_errors;
return missing_attribute_errors_enabled_;
}

bool unknown_processing_enabled() const {
return options_->unknown_processing !=
cel::UnknownProcessingOptions::kDisabled;
return unknown_processing_enabled_;
}

bool unknown_function_results_enabled() const {
return options_->unknown_processing ==
cel::UnknownProcessingOptions::kAttributeAndFunction;
return unknown_function_results_enabled_;
}

ComprehensionSlots& comprehension_slots() { return *slots_; }
Expand Down Expand Up @@ -294,6 +312,10 @@ class ExecutionFrameBase {
ComprehensionSlots* absl_nonnull slots_;
const int max_iterations_;
int iterations_;
const bool attribute_tracking_enabled_;
const bool missing_attribute_errors_enabled_;
const bool unknown_processing_enabled_;
const bool unknown_function_results_enabled_;
};

// ExecutionFrame manages the context needed for expression evaluation.
Expand Down
Loading