fix: preserve validation errors for numeric auth token options - #454
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid non-string values for
start_time,duration, orexpirationfail inside_ensure_int's exception handler: concatenating the value with a string raisesTypeError, masking the intendedValueError. For example,generate_auth_token(acl="*", duration=[300])never reaches the documented validation error.Format the value into the existing error message so invalid lists, dictionaries, and complex numbers consistently raise
ValueError. Add regression coverage for all three numeric options, including the existing invalid-string behavior.Validation: 150 auth-token and URL utility tests pass on Python 3.13, both without Django and with Django 5.2 installed. The new regression fails before the change.
git diff --checkpasses. The fulltestsuite was attempted but stopped at the first live API setup because this environment has no Cloudinary test account/network access for that run; live API coverage is not claimed.