Repository navigation
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An optional table on the membership step that shows suggested dues against income, like CATU's join page. Choosing a row selects that tier.
ck_join_flow_income_guidance_enabledfilter. With it off, nothing changes: no new settings, no table.Why
JOIN-150. GMTU members said seeing their dues against their income helps. This is built into the main plugin behind a flag so GMTU can switch it on from its add-on without other sites seeing any change.
How
Settings::isIncomeGuidanceEnabled()reads the filter.Settings::getMembershipPlanIncomeBands()andSettings::getIncomeGuidanceEnv()pass the bands, heading and note to the form;Blocks.phpmerges them in.IncomeGuidance(components/income-guidance.tsx) renders the table; the plan step selects a plan through the form, the same way a tier panel does.Tests
income-guidance-admin.spec.ts): the band and copy fields appear on the settings page and in the block editor with the flag on, and not at all with it off.income-guidance.spec.ts): the table's contents; choosing a row selects the tier and that tier reaches payment; clicking anywhere on a row; keyboard; choosing a tier marks its row; the phone layout; no table with the flag off; bands entered in the block editor appear on the published page.mu-plugins/), driven by an option so specs can turn it off.E2E setup fixes:
wp_slash()before saving. WordPress was stripping the backslashes from£in block JSON, turning£intou00a3.helpers.ts, for sharing.Follow-up
The GMTU add-on needs one line to switch this on (
add_filter('ck_join_flow_income_guidance_enabled', '__return_true');), plus a minimum parent version of 1.4.44. GMTU then enters its bands on the settings page.Test plan
🤖 Generated with Claude Code