Repository navigation
fix: support multiple lines in transaction note editing - #1361
Merged
Merged
Conversation
sneurlax
force-pushed
the
fix/305-multiline-transaction-notes
branch
from
May 28, 2026 16:50
3786f36 to
969e8e5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1361 +/- ##
===========================================
+ Coverage 7.71% 7.85% +0.14%
===========================================
Files 1125 1125
Lines 112816 112820 +4
===========================================
+ Hits 8701 8866 +165
+ Misses 104115 103954 -161 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dart format only; no behaviour change.
Transaction and trade notes were single-line fields that finalised the edit on Enter, so a note could never contain a line break. Give both a three to six line multiline field. On desktop the editor is hosted in a fixed height DesktopDialog, so scroll its body rather than let the grown field and the Save button paint outside the dialog card. Guards after the save await now use context.mounted.
sneurlax
force-pushed
the
fix/305-multiline-transaction-notes
branch
from
August 24, 2026 21:31
1394b64 to
40cc4f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #305