fix: is_same_host returns False for bare hostnames (no scheme) - #956
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
vuanhphung
approved these changes
Sep 30, 2026
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shubham-Padkonde
had a problem deploying
to
azure-prod
September 30, 2026 17:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
urlparse treats a string with no scheme as an opaque path, so
urlparse("host.example.com").netloc is "" while
urlparse("https://host.example.com").netloc is "host.example.com".
is_same_host therefore returned False whenever one of its arguments
lacked a scheme — for example a JWT iss claim stored as a bare
hostname vs. self.hostname which is always normalized with https://.
Fix: extract a nested helper _extract_host that re-parses with a
dummy "https://" prefix when the initial parse yields an empty
netloc, recovering the actual hostname in the bare-hostname case.
Also normalises extracted hosts to lowercase for a consistent
comparison.
Add four new parametrize cases to test_is_same_host covering the
previously failing mixed-scheme and bare-vs-bare comparisons.
Signed-off-by: Shubham-Padkonde <shubhampadkonde12@gmail.com>
Shubham-Padkonde
force-pushed
the
fix/is-same-host-bare-hostname
branch
from
October 2, 2026 13:29
7879395 to
045720b
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlparse treats a string with no scheme as an opaque path, so urlparse("host.example.com").netloc is "" while
urlparse("https://host.example.com").netloc is "host.example.com". is_same_host therefore returned False whenever one of its arguments lacked a scheme — for example a JWT iss claim stored as a bare hostname vs. self.hostname which is always normalized with https://.
Fix: extract a nested helper _extract_host that re-parses with a dummy "https://" prefix when the initial parse yields an empty netloc, recovering the actual hostname in the bare-hostname case. Also normalises extracted hosts to lowercase for a consistent comparison.
Add four new parametrize cases to test_is_same_host covering the previously failing mixed-scheme and bare-vs-bare comparisons.
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents