fix(hub-ui): keep language dropdown above embedded panels - #431
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
SaKaNa-Y
marked this pull request as ready for review
October 5, 2026 07:19
Contributor
Author
|
This fixes two issues with the language dropdown in Edge and Float modes. The settings panel covers the dropdown and prevents users from viewing and selecting languages. And when "Close panel on outside click" is enabled, clicking a language option closes the panel without changing the language. before: now: |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
In embedded Edge and Float modes, opening Settings → Appearance → Language places most language options behind the settings panel. The menu is mounted outside the panel in the same shadow root, but its display layer is lower than the panel's. With “Close panel on outside click” enabled, clicks on these options also count as outside clicks and close the settings panel before the selection takes effect.
Override the dropdown layer in Hub UI so menus appear above the embedded panel and below the command palette. Treat events through the embedded dock's custom element as inside clicks so users can select a language without closing the panel.
Validation:
pnpm lint,pnpm knip,pnpm test,pnpm typecheck, andpnpm buildpassed. Tests: 147 files passed; 1,639 tests passed and 13 skipped.