fix(deps): drop node-apk to remove vulnerable node-forge - #211
Merged
Merged
Conversation
node-apk pulled in node-forge, which has an unpatched high-severity advisory (GHSA-86w9-cpqp-85rv, RSA PKCS#1 v1.5 signature forgery) that fails `pnpm audit` on every PR. node-forge 1.4.0 is the latest release and the upstream fix (digitalbazaar/forge#1152) is unmerged a month on; node-apk itself hasn't been released since 2023. The CLI only ever needed the package name, so read it straight out of AndroidManifest.xml: node-stream-zip (already a dependency) extracts the entry and a small Android binary XML reader takes the root <manifest>'s package attribute. Checked against aapt2 and node-apk on 54 real APKs (fixtures, emulator overlays, customer reproduction binaries), all identical. Those all use UTF-16 string pools, so unit tests build UTF-8 and UTF-16 manifests by hand (both verified readable by aapt and aapt2) and cover the error paths. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-apk pulled in node-forge, which has an unpatched high-severity advisory (GHSA-86w9-cpqp-85rv, RSA PKCS#1 v1.5 signature forgery) that fails
pnpm auditon every PR. node-forge 1.4.0 is the latest release and the upstream fix (digitalbazaar/forge#1152) is unmerged a month on; node-apk itself hasn't been released since 2023.The CLI only ever needed the package name, so read it straight out of AndroidManifest.xml: node-stream-zip (already a dependency) extracts the entry and a small Android binary XML reader takes the root 's package attribute.
Checked against aapt2 and node-apk on 54 real APKs (fixtures, emulator overlays, customer reproduction binaries), all identical. Those all use UTF-16 string pools, so unit tests build UTF-8 and UTF-16 manifests by hand (both verified readable by aapt and aapt2) and cover the error paths.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test