Repository navigation
refactor(writer)!: remove WriteOptions#chunkSize - #422
Merged
Merged
Conversation
writeChunk never split batches by it: each call is one chunk. Its only effect was the zone-map stride, which was wrong whenever batches differed from it (#418) and is now derived from the real chunk lengths. A tuning knob that does nothing is a bug; remove it rather than keep a no-op. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #418/#421.
writeChunknever split batches byWriteOptions#chunkSize: each call is one chunk. The option's only effect was the zone-map stride, which was wrong whenever batches differed from it (#418) and is now derived from the real chunk lengths (#421). A tuning knob that does nothing is a bug, so it goes.Breaking:
WriteOptionsloses its first record component. The importers (csv,parquet,jdbc) batch with their ownImportOptions/JdbcImportOptions#chunkSizeand are unaffected. Call sites,docs/reference.mdand the CHANGELOG are updated.Full
./mvnw verifyis green locally.🤖 Generated with Claude Code