fix: extend digest verification to sha512 and set sandbox paths - #850
Open
ericcurtin wants to merge 1 commit into
Open
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Extend blob digest verification to cover sha512 in addition to sha256, closing a bypass where sha512-addressed blobs were stored without any integrity check. Set correct SandboxPath for Python backends (diffusers, mlx, vllm-metal) so the Darwin sandbox profile resolves UPDATEDLIBPATH to the sibling lib/ directory of the Python bin/ directory.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
WriteBlobWithResume, whendiffID.Algorithmis neithersha256norsha512the blob is now written without any integrity check; consider explicitly rejecting unsupported algorithms (or at least logging) instead of silently skipping verification.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `WriteBlobWithResume`, when `diffID.Algorithm` is neither `sha256` nor `sha512` the blob is now written without any integrity check; consider explicitly rejecting unsupported algorithms (or at least logging) instead of silently skipping verification.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for SHA-512 hashing in the blob store and updates the sandbox path configuration for several inference backends (Diffusers, MLX, and vLLM Metal) to ensure correct directory scoping. I have no feedback to provide.
ilopezluna
previously approved these changes
Apr 8, 2026
ilopezluna
self-requested a review
April 8, 2026 14:06
Contributor
I get this error in vllm-metal |
ilopezluna
dismissed
their stale review
April 8, 2026 17:10
I have realized it fails when using vllm-metal
sathiraumesh
reviewed
Apr 9, 2026
| var hasher hash.Hash | ||
| switch diffID.Algorithm { | ||
| case "sha256": | ||
| hasher = sha256.New() |
Contributor
There was a problem hiding this comment.
Just a suggestion, It may be better to move this to a separate function like
hasher(string algo) (has.Hash){
...
}
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved blob verification bypasses and custom Python sandbox path issues remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (4)
What changed in this PR
Extends blob integrity verification to SHA-512 and configures Darwin sandbox paths for Python backends.
Changes:
- Adds SHA-512 blob verification.
- Sets sandbox paths for MLX, Diffusers, and vLLM Metal.
| File | Summary | Findings |
|---|---|---|
pkg/inference/backends/vllm/vllm_metal.go |
Configures the vLLM Metal sandbox path. | Moderate (4 votes): custom Python paths may remain outside the sandbox. |
pkg/inference/backends/mlx/mlx.go |
Configures the MLX sandbox path. | None. |
pkg/inference/backends/diffusers/diffusers.go |
Configures the Diffusers sandbox path. | None. |
pkg/distribution/internal/store/blobs.go |
Adds SHA-512 verification. | Critical (3 votes): one-byte responses can bypass verification. Moderate (2 votes): resume logic still assumes SHA-256. Nit (4 votes): add SHA-512 success, mismatch, and cleanup tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| case "sha512": | ||
| hasher = sha512.New() | ||
| } | ||
| if hasher != nil { |
Comment on lines
+281
to
+287
| var hasher hash.Hash | ||
| switch diffID.Algorithm { | ||
| case "sha256": | ||
| hasher = sha256.New() | ||
| case "sha512": | ||
| hasher = sha512.New() | ||
| } |
| Socket: socket, | ||
| BinaryPath: v.pythonPath, | ||
| SandboxPath: v.installDir, | ||
| SandboxPath: filepath.Join(v.installDir, "bin"), |
Comment on lines
+285
to
+286
| case "sha512": | ||
| hasher = sha512.New() |
Comment on lines
+282
to
+286
| switch diffID.Algorithm { | ||
| case "sha256": | ||
| hasher = sha256.New() | ||
| case "sha512": | ||
| hasher = sha512.New() |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend blob digest verification to cover sha512 in addition to sha256, closing a bypass where sha512-addressed blobs were stored without any integrity check. Set correct SandboxPath for Python backends (diffusers, mlx, vllm-metal) so the Darwin sandbox profile resolves UPDATEDLIBPATH to the sibling lib/ directory of the Python bin/ directory.