Repository navigation
DX-126900: [Java][Gandiva] Report time64 types as TIME64 in the expression registry - #35
Open
akravchukdremio wants to merge 1 commit into
Open
akravchukdremio wants to merge 1 commit into
akravchukdremio wants to merge 1 commit into
Conversation
…ssion registry ArrowToProtobuf mapped arrow::Type::TIME64 to GandivaType::TIME32, so Java saw Time(MICROSECOND, 32) / Time(NANOSECOND, 32) instead of the 64-bit types and could never match Gandiva's time64 function signatures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
expression_registry_helper.ccmappedarrow::Type::TIME64toGandivaType::TIME32. Java therefore sawTime(MICROSECOND, 32)/Time(NANOSECOND, 32)inExpressionRegistry.getSupportedTypes()and in function signatures. It could never match the real 64-bitTIME(6)/TIME(9)types Dremio uses. This blocks Gandiva pushdown of the new time64 functions from dremio/arrow#146. Jira: https://dremio.atlassian.net/browse/DX-126900What changes are included in this PR?
TIME64→GandivaType::TIME64.ExpressionRegistryTest:testTimeTypesKeepBitWidthasserts Time32/Time64 are reported with the correct widths.testTime64Functionsasserts time64 signatures (extractHour,less_than,isnull) are visible from Java. This test requires the Gandiva C++ from DX-126900: [C++][Gandiva] Add TimeIR for unit-aware time64[us/ns] support arrow#146.Are these changes tested?
Yes. Locally built JNI against dremio/arrow#146:
ExpressionRegistryTest(6),ProjectorTest(43) andFilterTest(7) pass.Are there any user-facing changes?
Time64 types and functions are now reported correctly by the Gandiva expression registry.
Merge after dremio/arrow#146.
🤖 Generated with Claude Code