Repository navigation
bugc: add the % operator - #321
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG had no way to take a remainder. The IR already had a
modbinary op, the EVM generator already mapped it toMOD, and constant folding already handled it, so only the front end was missing. This adds%to the parser, at the same precedence as*and/, and lets the typechecker accept it on numeric operands. IR generation already mapped%tomod.BUG has no signed integer types, so
MODis the only opcode involved; there is noSMODcase. A zero divisor behaves as it does for/: the constant folder leavesx % 0alone, and at run time the EVM'sMODreturns 0.Tests cover parsing and precedence, typechecking, IR generation, constant folding, and a behavioral test that compiles and runs programs at optimization levels 0 through 3 (
1071 % 462is147, andx % 0is0, as isx / 0).