Polish documentation menus and page navigation - #220
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds subtle-hover theme tokens and applies them to shared menus, navigation, and documentation controls. It also changes brand-link styling and the layout of previous and next documentation cards. ChangesUI Styling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Merge Risk: ⚪ Minimal · up to The inspected styling changes preserve copying and previous/next page navigation. No actionable merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit taps a menu with care, Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/src/components/ui/menubar.tsx">
<violation number="1" location="apps/web/src/components/ui/menubar.tsx:26">
P3: This adds a `menuItemStyles` constant byte-identical to the one in dropdown-menu.tsx, splitting one shared definition across two files just as the PR was unifying menu styling. Export it from dropdown-menu.tsx (or a shared constants module) and import it here so future spacing/color tweaks stay in sync.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| import { cn } from "@/lib/utils"; | ||
|
|
||
| const menuItemStyles = | ||
| "relative flex cursor-default items-center gap-1.5 rounded-xs min-h-6.75 px-2 py-0.5 text-sm text-muted-foreground outline-hidden select-none focus:bg-subtle-hover focus:text-subtle-hover-foreground data-inset:pl-7 data-disabled:pointer-events-none data-disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg]:size-3.5"; |
There was a problem hiding this comment.
P3: This adds a menuItemStyles constant byte-identical to the one in dropdown-menu.tsx, splitting one shared definition across two files just as the PR was unifying menu styling. Export it from dropdown-menu.tsx (or a shared constants module) and import it here so future spacing/color tweaks stay in sync.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/src/components/ui/menubar.tsx, line 26:
<comment>This adds a `menuItemStyles` constant byte-identical to the one in dropdown-menu.tsx, splitting one shared definition across two files just as the PR was unifying menu styling. Export it from dropdown-menu.tsx (or a shared constants module) and import it here so future spacing/color tweaks stay in sync.</comment>
<file context>
@@ -22,6 +22,9 @@ import {
import { cn } from "@/lib/utils";
+const menuItemStyles =
+ "relative flex cursor-default items-center gap-1.5 rounded-xs min-h-6.75 px-2 py-0.5 text-sm text-muted-foreground outline-hidden select-none focus:bg-subtle-hover focus:text-subtle-hover-foreground data-inset:pl-7 data-disabled:pointer-events-none data-disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg]:size-3.5";
+
function Menubar({ className, ...props }: MenubarPrimitive.Props) {
</file context>
This branch was successfully deployed
1 participant
Summary
Validation
pnpm --filter web lintpnpm --filter web typecheckpnpm exec oxfmt --checkon changed filesSummary by cubic
Standardizes hover and menu styling across documentation and navigation components using new shared color tokens, and restyles previous/next page links to match the Copy Page inset-card treatment.
Key changes
subtle-hover,subtle-hover-border, andsubtle-hover-foregroundtokens for both light and dark themes.mutedto the newsubtle-hovertoken.Written for commit 7e1ffc5. Summary will update on new commits.
Summary by CodeRabbit