Repository navigation
Conversation
JPeer264
added this pull request to stack #25002
October 2, 2026 13:14
Contributor
size-limit report 📦
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JPeer264
removed this pull request from stack #25002
October 2, 2026 13:31
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 2, 2026 13:39
4086ec4 to
284747b
Compare
JPeer264
added this pull request to stack #25004
October 2, 2026 13:57
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 2, 2026 16:59
284747b to
c22dbd7
Compare
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 3, 2026 16:23
c22dbd7 to
c15fabf
Compare
JPeer264
removed this pull request from stack #25004
October 5, 2026 07:21
JPeer264
added this pull request to stack #25029
October 5, 2026 07:22
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 5, 2026 09:44
c15fabf to
11517b6
Compare
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
2 times, most recently
from
October 5, 2026 12:39
5d261da to
9f735f8
Compare
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 5, 2026 12:53
9f735f8 to
07ef6c3
Compare
JPeer264
marked this pull request as ready for review
October 5, 2026 13:33
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
2 times, most recently
from
October 6, 2026 07:55
b871dfa to
66db439
Compare
andreiborza
approved these changes
Oct 6, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Could we also send the data to sentry?
| @@ -0,0 +1,188 @@ | |||
| import { expect, test } from '@playwright/test'; | |||
Member
There was a problem hiding this comment.
l: Let's use constants from sentry conventions as much as possible here too please.
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 7, 2026 09:05
66db439 to
e519aa4
Compare
Member
Author
We could. I just don't see the benefit yet of having a send-to-sentry test for this, unless you want to have 100% coverage of agentic harnesses / models being tested on deployed workers |
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 7, 2026 11:01
e519aa4 to
1cb9e0a
Compare
Member
Hm no it's fine, let's ship without. |
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 7, 2026 13:51
df857f5 to
8151a76
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Covers what the node integration test cannot: the packed SDK, real model requests through pi-ai's `@anthropic-ai/sdk` path, SQLite storage, and a run that resumes after the server crashes during a tool call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/pi-durable-e2e
branch
from
October 7, 2026 17:03
8151a76 to
639b635
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an E2E app for the pi-durable instrumentation. It covers what the node integration test cannot: the packed SDK loaded with
--import, real model requests through OpenRouter, SQLite storage, a subagent, and a run that resumes after the server crashes during a tool call. A small supervisor restarts the server for that case, as a process manager would.pi-ai sends
anthropic/claude-haiku-4.5through@anthropic-ai/sdk, so the first test also checks that each model request is reported once and that the provider's HTTP call nests inside itschatspan.The app is optional with a
latestvariant, becauseE2E_OPENROUTER_API_KEYis only available in the optional E2E job.🤖 Generated with Claude Code