perf: skip structural sharing on the notifications query - #3320
Open
fmguerreiro wants to merge 1 commit into
Open
fmguerreiro wants to merge 1 commit into
fmguerreiro wants to merge 1 commit into
Conversation
This was referenced Sep 18, 2026
Marking a notification froze the renderer for 8.5s on a 1274-notification inbox: every cache write deep-compared the enriched tree.
setchy
force-pushed
the
perf/skip-structural-sharing
branch
from
October 4, 2026 11:21
0ea20b5 to
1cf0391
Compare
setchy
marked this pull request as ready for review
October 4, 2026 11:21
setchy
approved these changes
Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every write to the notifications query deep-compares the whole cached tree, so marking one notification walks every notification in the inbox, and each poll pays it again. This turns structural sharing off for that query.
Trade: each poll now returns fresh objects, so every mounted row re-renders. #3319 (virtualize the notification list) is now merged into
main, so only the visible rows are mounted and that cost stays bounded.Split out of #3319, as @setchy asked.
Refresh
main; the branch is now a single commit with no merge commit.