Skip to content

Simplify EMM Tests - #641

Open
w-goog wants to merge 2 commits into
mainfrom
test/emm-handler-test-helpers
Open

w-goog wants to merge 2 commits into
mainfrom
test/emm-handler-test-helpers

Conversation

@w-goog

@w-goog w-goog commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

This PR simplifies the EMM test code, so that an upcoming change is more intelligible and easier to verify.

In detail:

  • Removes the pre-iOS-8 branch of UIAlertController checks.
  • Pulls the UIAlertController taps & content checking into helpers
  • Pulls the main thread waits into a helper.
  • Pulls the "expected a presented alert" check into a helper.

@w-goog
w-goog marked this pull request as ready for review September 28, 2026 22:14
@w-goog
w-goog added this pull request to stack #643 September 28, 2026 22:59
@w-goog
w-goog requested a review from brnnmrls September 28, 2026 22:59
@brnnmrls

Copy link
Copy Markdown
Member

Amazing cleanup, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants