Skip to content

test: Cover stateless GitHub App token format - #4598

Open
rajveer002 wants to merge 2 commits into
google:masterfrom
rajveer002:stateless-token-regression
Open

rajveer002 wants to merge 2 commits into
google:masterfrom
rajveer002:stateless-token-regression

Conversation

@rajveer002

@rajveer002 rajveer002 commented Sep 27, 2026 •

Copy link
Copy Markdown

Summary

Add focused regression coverage for the newer stateless GitHub App installation-token format.

The test uses a realistic long opaque token containing multiple segments and separators (. and _) and verifies that CreateInstallationToken preserves the token exactly, including its full length and content.

Why

The repository already has long-token coverage using repeated characters. This adds coverage for the structured stateless-token shape, helping guard against assumptions about token length or character layout.

Testing

  • go test ./github -count=1 passed locally.
  • git diff --check passed before commit.

@google-cla

google-cla Bot commented Sep 27, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title test: cover stateless GitHub App token format test: Cover stateless GitHub App token format Sep 30, 2026
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (48d0a66) to head (7bc7601).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4598   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         197      197           
  Lines       18326    18326           
=======================================
  Hits        18068    18068           
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

gmlewis commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

@rajveer002 - once you fix the linter issues (you can run ./script/lint.sh locally) and push the changes, we can start moving forward with this PR.

@gmlewis gmlewis added waiting for reply and removed NeedsReview PR is awaiting a review before merging. labels Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants