test: Cover stateless GitHub App token format - #4598
Open
rajveer002 wants to merge 2 commits into
Open
rajveer002 wants to merge 2 commits into
rajveer002 wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 197 197
Lines 18326 18326
=======================================
Hits 18068 18068
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@rajveer002 - once you fix the linter issues (you can run ./script/lint.sh locally) and push the changes, we can start moving forward with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused regression coverage for the newer stateless GitHub App installation-token format.
The test uses a realistic long opaque token containing multiple segments and separators (
.and_) and verifies thatCreateInstallationTokenpreserves the token exactly, including its full length and content.Why
The repository already has long-token coverage using repeated characters. This adds coverage for the structured stateless-token shape, helping guard against assumptions about token length or character layout.
Testing
go test ./github -count=1passed locally.git diff --checkpassed before commit.