fix(docker-promote): quote version in tag suffix removal - #171
Merged
Merged
Conversation
The unquoted `$version` inside `${TAG%-v$version}` was interpreted as a glob pattern (shellcheck SC2295), so glob characters in a version would strip more than the literal `-v<version>` suffix. Quote it so the suffix is matched literally. Release-please versions never contain glob characters, so the computed component is unchanged in practice.
jbern0rd
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unquoted
$versioninside${TAG%-v$version}was interpreted as a glob pattern (shellcheck SC2295), so glob characters in a version would strip more than the literal-v<version>suffix. Quote it so the suffix is matched literally. Release-please versions never contain glob characters, so the computed component is unchanged in practice.