Conversation
Member
|
What is the downside to adding JuliaC as an explicit test dependency? Does it work with Julia v1.10? |
Member
|
This is the way to do it though. We just gradually add more things to the |
Member
Why? |
odow
changed the title
odow
reviewed
Sep 30, 2026
| image_recipe = JuliaC.ImageRecipe( | ||
| output_type = "--output-exe", | ||
| file = joinpath(@__DIR__, "MyApp"), | ||
| trim_mode = "no", |
Member
There was a problem hiding this comment.
So there's a design question here: what's the point of testing this with trim_mode = no? Shouldn't we test only with safe or unsafe-warn? I don't see how writing a JSON file can ever be type-stable.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For JuMPy, I'd like to have, in addition to the HiGHS backend, a backend that just writes a MOF so it would be nice to have the MOF writer trimable. It was actually not too hard if we just want
--trim=unsafe-warn, the full change is inbl/juliacbut I split it in separate PRs.--trim=safeis quite hard but it's easy to know whether the warning thrown by--trim=unsafe-warnare going to be an issue or not. If a user ends up calling a method that was missing from the JuliaC binary, he just gets aMethodErrorso it's easy to see what's happening. So--trim=unsafe-warnis a nice target.We start with
--trim=no, same reason as jump-dev/HiGHS.jl#372 (comment)