feat: Suppress individual events and split summary counters for override-affected evaluations - #223
Draft
kinyoklion wants to merge 1 commit into
Conversation
kinyoklion
force-pushed
the
rlamb/overrides-java-override-layer
branch
from
September 28, 2026 21:04
3ddbca0 to
51b497a
Compare
kinyoklion
force-pushed
the
rlamb/overrides-java-override-events
branch
from
September 28, 2026 21:04
bd3633b to
e1dd774
Compare
kinyoklion
force-pushed
the
rlamb/overrides-java-override-layer
branch
from
October 1, 2026 23:44
51b497a to
3e12570
Compare
kinyoklion
force-pushed
the
rlamb/overrides-java-override-events
branch
from
October 1, 2026 23:44
e1dd774 to
752e614
Compare
kinyoklion
force-pushed
the
rlamb/overrides-java-override-layer
branch
from
October 3, 2026 00:58
3e12570 to
2d12762
Compare
kinyoklion
force-pushed
the
rlamb/overrides-java-override-events
branch
from
October 3, 2026 00:58
752e614 to
f76f228
Compare
Member
Author
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f76f228. Configure here.
…ide-affected evaluations The OVERRIDE specification requires an override-affected evaluation to produce no individual feature event and no debug event, whatever the flag requests, while still being counted in summary events under a separate counter that carries the overrideAffected marker. A prerequisite record carries the prerequisite's own marking. EventProcessor gains an overload of recordEvaluationEvent with the marking. It is a default method that delegates to the existing method, so custom implementations keep compiling. The SDK's implementations override it and the evaluator's event recorder passes the evaluation result's marking for top-level, prerequisite, and requested-type mismatch records. Event generation keys on that value alone. The server SDK now depends on launchdarkly-java-sdk-internal 1.13.0, which carries the marker through Event.FeatureRequest, the summarizer, the output formatter, and the event processor. CI for this change cannot pass until that version is released. The specification's vector runner now also asserts the per-evaluation summary marking. Flag overrides are currently experimental and subject to change.
kinyoklion
force-pushed
the
rlamb/overrides-java-override-events
branch
from
October 3, 2026 01:43
f76f228 to
b03ecdf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This connects the override-affected marking of an evaluation to analytics events, as the OVERRIDE specification requires. An evaluation that read a definition from the override store, directly or through a prerequisite or a segment, produces no individual feature event and no debug event, whatever the flag's configuration requests. It is still counted in summary events, in a separate counter that carries
overrideAffected: true, so LaunchDarkly can tell override-affected counts from ordinary counts of the same flag, variation, and version. A prerequisite record carries the prerequisite's own marking: an unaffected prerequisite evaluated inside a marked evaluation still produces its individual event.EventProcessorgains an overload ofrecordEvaluationEventwith the marking. It is a default method that ignores the marking and delegates to the existing method, so a custom implementation keeps compiling and behaving as before. The SDK's implementations override it.Flag overrides are currently experimental and subject to change.
This PR depends on the override layer change (rlamb/overrides-java-override-layer) and is based on that branch; retarget it to feat/overrides once that branch merges.
The existing file data source keeps its current behavior; this change does not touch its code paths.
SDK-3246
Note
Overview
Wires override-affected evaluations into the server SDK’s event pipeline per the OVERRIDE spec. Evaluations that read from the override store (flag, prerequisite chain, or segment) now pass an
overrideAffectedflag into the event processor; the bumped launchdarkly-java-sdk-internal 1.13.0 uses that to skip individual feature and debug events while still counting them in summary counters tagged withoverrideAffected: true.EventProcessoradds an overload ofrecordEvaluationEventwith the marking; the default method delegates to the old signature so custom processors keep working. The evaluator’sEvaluationRecorderforwardsEvalResult.isOverrideAffected()for normal, prerequisite, and type-mismatch records (exceptions recordfalse). Prerequisite events carry each prereq’s own marking, independent of the parent flag.Tests cover marking behavior end-to-end (including flushed analytics payloads) and the OVERRIDE vector runner now asserts
summaryOverrideAffected.Reviewed by Cursor Bugbot for commit f76f228. Bugbot is set up for automated code reviews on this repo. Configure here.