Skip to content

fix(dune): declare package dependencies - #18

Merged
RCmerci merged 1 commit into
mainfrom
fix/dune-package-dependencies
Sep 26, 2026
Merged

RCmerci merged 1 commit into
mainfrom
fix/dune-package-dependencies

Conversation

@RCmerci

@RCmerci RCmerci commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Declare dependencies for all five packages in dune-project, matching their existing opam metadata.
  • Allow Dune package management to resolve transitive dependencies when the packages are pinned from a consuming project.

Verification

  • dune build -p datascript_ocaml -j 8 passed.
  • With this branch pinned locally in Logseq's DB worker, dune pkg lock resolved the additional persistent_sorted_set_ocaml dependency, and dune build @pkg-install installed the DataScript packages without the previous missing-library errors.
  • The full DB worker package installation later stopped while compiling the separately pinned mldoc: its unsafe_lookahead reference is unresolved against the pinned angstrom revision.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T05:35:06.969785Z 4beaf28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 1e9cc69 into main Sep 26, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant