Fix flaky diagnostic added by declaration emit through MarkLinkedReferencesRecursively - #64482
Merged
Wesley Wigham (weswigham) merged 2 commits intoSep 30, 2026
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 27, 2026 16:59
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted guard correctly prevents declaration names from being resolved as references, with focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents emit-time resolution of function/class expression declaration names from introducing flaky diagnostics.
Changes:
- Excludes declaration names from linked-reference resolution.
- Adds regression coverage and generated emit/type/symbol baselines.
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Skips declaration names during expression-reference marking. |
tsc/testdata/tests/cases/compiler/noFlakyDiagnosticsExpressionNameShadowedInBody1.ts |
Covers shadowed function and class expression names. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsExpressionNameShadowedInBody1.js |
Records JavaScript emit. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsExpressionNameShadowedInBody1.symbols |
Records symbol resolution. |
tsc/testdata/baselines/reference/compiler/noFlakyDiagnosticsExpressionNameShadowedInBody1.types |
Records inferred types. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Wesley Wigham (weswigham)
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a crash reported here: #64458 (comment)