docs(ops): make site monitoring aware of log rotation - #3753
Merged
Merged
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the product-site monitoring procedure so an empty current log file cannot be mistaken for a healthy service after log rotation.
The completed 24-hour follow-up found live Nginx descriptors still writing
.log.1while current.logpaths were empty. Read-only diagnosis also found an empty configured PID file and a failed systemd unit while the manual master continued serving. The packaged rotate selector, run with--testonly, returned no matching process; its init-script wrapper is written to return success unconditionally. This establishes the current control-path mismatch, not the event that originally emptied the PID file.tailand user-agent-filtered route counting with an explicit, numeric master-PID guard and read-only descriptor/inode inspection.Validation
bash -non monitoring blocks andgit diff --checkpass.dce73ccb98a3a4c65cb08119ed745e488c5260a9: Product site run 36943928705 completed successfully. Downloaded job logs show 46 legacy-link tests, 524 build/validation tests, 315 additional selected tests, 2 browser-preparation tests, and 154 browser tests passing. Deselected cases are not counted as executed tests.Integration
Merged as
14f12f1dc04418c3a2cd28e29623d1ad810c6d35after fresh exact-head checks and the existing administrator merge exemption, without changing repository policy. Both merge parents and tree23bd6e5b337ab00dbec69b607a4c49bc7833e8cbmatch the validated candidate.Exact-merge Product site run 36951173195 and Update API Documentation run 36951173119 both completed successfully. Downloaded product-site job logs again show 46, 524, 315, 2, and 154 passing tests in the respective stages described above, with 3 and 6 explicitly deselected cases in the two selected-test stages. All returned head/merge check runs are terminal and successful. No full native site-suite execution is claimed beyond the eight focused native regressions.
Only the operations document and its existing test module change. No production PID-file/configuration write, service action, signal, restart, log reopen, deployment, rollback, model operation, or package release. The operational logging defect remains unresolved; this PR fixes the misleading acceptance procedure, not Nginx process ownership.