Skip to content

fix(release): pin Bun 1.3.14 for release binaries #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heimanba merged 2 commits into from
Sep 28, 2026
Merged

fix(release): pin Bun 1.3.14 for release binaries #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09afb80
fix(release): pin Bun 1.3.14 for release binaries
duck-bubi-ya Sep 28, 2026
ff52ede
chore(release): remove the Bun pin commentary
duck-bubi-ya Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
# Keep this pin in sync with any local smoke tests of binary-compile.mjs.
- uses: oven-sh/setup-bun@v2
with:
bun-version: "1.2.19"
bun-version: "1.3.14"

- name: publish-stable
env:
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
# Keep this pin in sync with any local smoke tests of binary-compile.mjs.
- uses: oven-sh/setup-bun@v2
with:
bun-version: "1.2.19"
bun-version: "1.3.14"

- name: publish-channel
env:
Expand Down
2 changes: 1 addition & 1 deletion tools/release/lib/binary-build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ function compileOne({ bunTarget, os, arch, exe }, version, outdir, entry) {
}
if (result.stdout) process.stdout.write(result.stdout);
if (result.stderr) process.stderr.write(result.stderr);
// Bun 1.2.19 writes windows-x64 .exe with mode 000 on Unix hosts (oven-sh/bun#21308).
// Bun has written windows-x64 .exe as mode 000 on Unix hosts (oven-sh/bun#21308).
chmodSync(innerPath, 0o755);
// Sign after chmod. Bun's linker signature does not match the final Mach-O bytes.
if (os === "darwin") signDarwinAdhoc(innerPath, { log });
Expand Down
2 changes: 1 addition & 1 deletion tools/release/lib/binary-compile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* bun tools/release/lib/binary-compile.mjs --entry <path> --outfile <path> --target <bun-target>
*
* Uses `bun build --compile` (CLI). The Bun.build({ compile }) API on ≤1.2.19
* can exit 0 without writing outfile; CI pins 1.2.19 so we stay on the CLI.
* can exit 0 without writing outfile; CI stays on the CLI.
*
* Called by binary-build.mjs (Node orchestration stays on Node).
*/
Expand Down
Loading