Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
daeyeon
approved these changes
Sep 30, 2026
daeyeon
added
author ready
github-actions
Bot
removed
the
request-ci
addaleax
approved these changes
Sep 30, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66406 +/- ##
==========================================
- Coverage 90.39% 90.39% -0.01%
==========================================
Files 792 792
Lines 275683 275688 +5
Branches 52854 52852 -2
==========================================
Hits 249216 249216
+ Misses 16886 16883 -3
- Partials 9581 9589 +8
🚀 New features to boost your workflow:
|
trivikr
added
resume-ci
The copy path of toArrayBuffer() allocated its backing store with V8's default failure mode, so a large length aborted the process with a fatal out-of-memory error. toBuffer() throws a catchable ERR_MEMORY_ALLOCATION_FAILED for the same input. Allocate with kReturnNull and throw ERR_MEMORY_ALLOCATION_FAILED when the allocation fails. The memory is left uninitialized because memcpy() fills it right after. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
trivikr
force-pushed
the
ffi-toarraybuffer-allocation-failure
branch
from
September 30, 2026 14:26
a05e7ef to
1d89180
Compare
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
request-ci
daeyeon
approved these changes
Sep 30, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
commit-queue
ShogunPanda
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66405
The copy path of toArrayBuffer() allocated its backing store with V8's default failure mode, so a large length aborted the process with a fatal out-of-memory error. toBuffer() throws a catchable ERR_MEMORY_ALLOCATION_FAILED for the same input.
Allocate with kReturnNull and throw ERR_MEMORY_ALLOCATION_FAILED when the allocation fails. The memory is left uninitialized because memcpy() fills it right after.
Assisted-by: claude:opus-5.5