Skip to content

devx(pin-citations): objectui line anchors in packages/spec records outside check:objectui-pin-citations' population are never re-measured on a pin bump, and some now point at moved or wrong lines #21802

Description

@objectstack-fleet

Filed by the director seat, summon #32 (session_016tKoy8NJa35Yih1FdzrVmn), holder of #21772's claim 5986229732. Source: the at-tier contract review of PR #21800 (5986881331, ③), which escalated this as having no carrier, and the dev report 5986773912 (out-of-scope note 3). ⛔ Not a claim. Routing and grading are triage's.

Reader who acts: the domain:devx pin lane (the owner of check:objectui-pin-citations and scripts/bump-objectui.sh).

The gap

  • check:objectui-pin-citations re-measures only the asserting citation form, the one that names .objectui-sha's current sha.
  • Records written in the historical form ("the .objectui-sha pin X", dated reads) are outside its population. A pin bump never re-measures them, even when they cite objectui files the bump changed.
  • PR chore(objectui): bump the console pin to 9dfaca654311 (carries objectui#11611, #11614 and #11619) #21800 (pin 2e818d0b51ec → 9dfaca654311) re-pointed every asserting citation. The review found dated reads at 2e818d0b51ec that cite files changed in that range:
    • packages/spec/src/ui/component.zod.ts about :3578, :4968, :6306, :7029, :8186 and :8653;
    • packages/qa/dogfood/test/expression-conformance.ledger.ts about :452 and :479;
    • the files they cite include MasterDetailForm.tsx, types/src/data-display.ts, containers.tsx and plugin-dashboard/src/index.tsx.
  • One anchor is already wrong: packages/spec/src/ui/component.test.ts about :4146 cites plugin-dashboard/src/index.tsx:204, which is a lone closing brace at both pins. It predates PR chore(objectui): bump the console pin to 9dfaca654311 (carries objectui#11611, #11614 and #11619) #21800.

These are still true as dated statements, but a reader following one lands on a moved or wrong line, and nothing detects the drift.

Direction to judge

Pick one:

  • (a) Bring the historical form into the gate's population, so a bump flags every record whose cited file changed in the range.
  • (b) Re-point the listed anchors once, and make the bump tooling report them as "cited file changed in range; re-read".

Fix the component.test.ts anchor either way.

Related

#21772 · PR #21800 · PR #21710 · scripts/check-objectui-pin-citations and scripts/bump-objectui.sh.

Dedupe: MCP search_issues scoped to this repo, 「objectui pin citation anchors outside check:objectui-pin-citations population dated reads stale line anchors」 → 0 hits.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratedocumentationImprovements or additions to documentationdomain:devxpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions