Skip to content

docs(ci): re-derive the CLI whole-fit bound on the refreshed shard-timings dataset - #21966

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-21758-shard-fit-after-refresh
Oct 6, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-21758-shard-fit-after-refresh

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #21758
Clause-②: no

This PR covers triage's direction 5982304306, steps 2 to 4. Step 1 (option A, the re-measure) is the refresh that already landed as f2aa0c9fad. The only thing left open is the seat's reading on the next hourly full run after this lands.

The diff is one comment block in scripts/partition-test-shards.mjs. No code changed. FILE_SHARDED_PACKAGES is unchanged (still empty), and so are test-shard-timings.json, ci.yml and every timeout.

Step 2: the docblock is corrected

The FILE_SHARDED_PACKAGES docblock argued that the CLI "fits whole until ~1852s". It reached that by solving the bound against a 733.33 s entry. That entry was the CLI's two slice windows summed within one run (run 36380128221, the only sample that refresh had). It was not a whole-suite window. Once the CLI ran whole, its windows read 1659.03 s and 1667.97 s, which is 2.26 to 2.27 times that entry. The conclusion held, because both readings are under ~1852 s, but the figure behind it was wrong.

The block now records that, and it re-derives the bound on the dataset that measured the CLI whole.

Step 3: option B is not indicated (the arithmetic)

Dataset. scripts/test-shard-timings.json at origin/main 01e0f71a, blob 12c2460c00. That blob is identical to f2aa0c9fad, the #21826 refresh.

  • It was measured from run 37262126122: 72 packages, 9781.33 s in total.
  • @objectstack/cli reads 1702.69 s and is now the heaviest item.
  • @objectstack/dogfood, the only --exclude in ci.yml, is not in the dataset.

The rule used is the partitioner's own, not a paraphrase. meetsBound (pins 2 and 3) requires both of these:

  • the heaviest bin is at most MAX_SHARD_OVER_MEAN (1.3) times the mean;
  • no single item is heavier than 1.3 times the mean.

When the CLI is the heaviest item and sits alone in a bin, both halves reduce to C ≤ (1.3/6)(R + C), where C is the CLI's weight and R is everything else.

Numbers.

  • R = 8078.64 s.
  • Mean = 9781.33 / 6 = 1630.22 s.
  • Bound = 1.3 × 1630.22 = 2119.29 s.
  • CLI/mean = 1702.69 / 1630.22 = 1.044, inside 1.3.
  • Solving for C: C_max = 1.3 × 8078.64 / 4.7 ≈ 2234.5 s. That is 1.31 times the CLI's dataset entry, and 1.27 times its worst reading since the refresh (1753.66 s, run 37415122516).
CLI weight max/mean heaviest item
whole, as in the dataset (1702.69 s) 1.044 1703 s (cli)
sliced at 2 1.002 1135 s (spec)
whole at its worst since (1753.66 s) 1.070 1754 s (cli)

Slicing at 2 would lower the maximum, but the bound already holds at n = 1. Pin 3c's own derivation refuses a { '@objectstack/cli': 2 } entry on this dataset ("at 1 the split already meets 1.3x (max/mean 1.04x, heaviest item 1703s against a 1630s mean). Retire the entry"). So option B is not taken.

Because FILE_SHARDED_PACKAGES did not change, the Test Core matrix and the required-check names (Test Core (N/6) and the aggregate Test Core) do not change either.

The 6 bins the landed dataset produces (full list, as the hourly run splits it)

shard predicted share of mean items contents
1/6 1702.69 s 1.044 1 cli
2/6 1614.77 s 0.991 12 spec, service-messaging, plugin-audit, mcp, …
3/6 1615.33 s 0.991 15 metadata-protocol, service-analytics, verify, cloud-connection, …
4/6 1615.40 s 0.991 15 objectql, service-automation, client, lint, …
5/6 1616.73 s 0.992 15 rest, plugin-auth, plugin-approvals, driver-turso, …
6/6 1616.41 s 0.992 14 runtime, plugin-security, driver-sql, plugin-sharing, …

The partitioner's own self-test prints the same bins: bins 1703/1615/1615/1615/1617/1616s.

Step 4: second samples (reported here, not written into the dataset)

Source. Each reading is a turbo execution window for a task that actually ran (a cache MISS). It comes from the report-test-timings merged table that the aggregate Test Core job echoes into its log, read with the GitHub MCP get_job_logs read tool.

  • The test-core-run-summary-* artifacts and the raw job-log REST endpoint are both unreadable from this container: gh api …/actions/jobs/112121376726/logs refuses the redirect to productionresultssa16.blob.core.windows.net.
  • The merged table lists only the 10 slowest packages per run.

Each ratio is the reading divided by the landed dataset value.

package (dataset) 37421524959 schedule @ 76fec88 37415122516 push @ 3c7785d 37419396793 push @ 76fec88 37416453417 schedule @ 3c7785d
plugin-auth (364.98 s) 393.33 s, 1.08× 387.53 s, 1.06× 231.44 s, 0.63× cache replay, NOT MEASURED
metadata-protocol (566.45 s) 372.89 s, 0.66× 549.06 s, 0.97× not in the top-10 (cutoff 150.51 s), NOT MEASURED cache replay, NOT MEASURED
cli (1702.69 s) 1723.05 s, 1.01× 1753.66 s, 1.03× 1721.19 s, 1.01× 1033.74 s, 0.61×

Seat 1's pre-refresh executed readings (5982793172), divided by the new values:

  • plugin-auth: 297.82 / 417.15 / 320.88 s, which is 0.82× / 1.14× / 0.88×;
  • metadata-protocol: 511.20 / 426.17 s, which is 0.90× / 0.75×.

Every sample for both packages is under 1.5× against the landed dataset. The highest are plugin-auth at 1.14× and metadata-protocol at 0.97×.

Early reading toward the acceptance (not the seat's post-landing reading)

This PR changes no code, so the partition on main is already the one above. Two post-refresh hourly full runs exist:

  • Shard 1/6 (cli alone): measured/predicted is 0.61× in 37416453417 and 1.01× in 37421524959.
  • Shards 2 to 6: NOT MEASURED here. A shard's ratio needs every package window on it. Those windows are only in the run-summary artifacts, which this container cannot reach, and the merged table names 10 packages. In 37421524959 all ten listed packages read between 0.66× and 1.21×.

Acceptance notes (noted, not filed)

Verification (head cb3f093c)

  • node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 30 commands from the merge base 01e0f71ad, the same 30 the dispatch named.
    • All 30 exited 0, with each exit code written to disk.
    • --ran reconciliation: ✓ dispatch-gates --ran: 30 derived famil(ies) accounted for — 30 run, 0 NOT-MEASURED (a DERIVED zero …).
    • node scripts/partition-test-shards.mjs --self-test: self-test OK (72 measured packages -> 72 shard items, 6 shards, max/mean 1.04x …, floor 1703s, bins 1703/1615/1615/1615/1617/1616s, file-level slices: none), where the elided part states the 1.3x bound.
    • pnpm check:pm-dispatch-gates: ✓ dispatch-gates self-test: 1976 cases pass.
    • pnpm check:nul-bytes: OK (scanned 10322 text file(s) … no raw ASCII control bytes).
  • Extra runs, for rosters under scripts/: node scripts/check-published-list-mirrors.mjs and node scripts/measure-test-shard-timings.mjs --self-test both exit 0.
  • No *.test.* file names this script (zero hits; the control grep for scripts/ over the same pathspec has 383 hits).
  • eslint, narrowed to this one file:
    • eslint --no-inline-config --format json scripts/partition-test-shards.mjs gives 1 file, 0 errors, 0 warnings.
    • The file is in the population of eslint.config.mjs's **/*.{…,mjs,…} object; --print-config shows 2 rules and parserOptions {ecmaVersion, sourceType}.
    • The config enables no type-aware linting (no parserOptions.project or projectService anywhere), so a comment edit in one file cannot change any other file's result. The full pnpm lint run is CI's.
  • No changeset: root scripts/ only, private, nothing publishes, so skip-changeset.

The holder of this card ran out of session tokens. This PR continues the existing branch claude/issue-21758-shard-fit-after-refresh as a takeover (Release:/Claim: 6010756437), by domain:devx seat 2, session session_01VF48aw8RPG6wzDnMgp6rtw.


Generated by Claude Code

claude added 2 commits October 6, 2026 06:35
…red it whole

The partitioner's FILE_SHARDED_PACKAGES docblock argued that the CLI fits
whole up to ~1852s from a 733.33s entry, which was the CLI's two slice
windows summed within one run, not a whole-suite window. Whole-suite
windows later read 1659-1668s.

Re-derived on the refreshed dataset (run 37262126122, 72 packages,
9781.33s, CLI 1702.69s): mean 1630.22s, bound 2119.29s, max/mean 1.044x
with the CLI alone in bin 1, fit limit C <= (1.3/6)(8078.64 + C) = ~2234s.
n = 1 is still the derived answer, so the slice map stays empty.
Comment-only change.

Claude-Session: https://claude.ai/code/session_01VF48aw8RPG6wzDnMgp6rtw
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the size/s label Oct 6, 2026
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 6, 2026
@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 6, 2026 07:34
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 6, 2026 07:34
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 4c49150 Oct 6, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-21758-shard-fit-after-refresh branch October 6, 2026 08:12
akarma-synetal pushed a commit to akarma-synetal/framework that referenced this pull request Oct 7, 2026
… decision in words instead of a tracker number (stage 25) (objectstack-ai#21975)

Part of objectstack-ai#20749
Clause-②: no

Stage 25 of this card: the next area of class (e), the test strings
shipped under `packages/spec/src`, as ruled in `5902360492` on objectstack-ai#20513.
This stage takes the second and last name-ordered `api/` group: the 13
id-bearing test files directly under `packages/spec/src/api/` from
`plugin-rest-api.handler-status-retirement.test.ts` to
`zod-issues-to-fields.test.ts`. Those files carried 89 messages and 95
tracker ids, citing 43 records. All 95 now either state what their
record decided, in words (form D), or are dropped where the title
already says it. No needle sits in this group. Text only: no assertion,
identifier, test count or code comment changes, and no file is renamed.
With this stage, `api/` carries no tracker id in a test string.

## Census at the base (`5a22eb5619`)

Instruments: `census10.cjs` (md5 `9d08602ab972b4b8643c90d64d40fa41`),
`census.cjs` (md5 `6e42a45a926d375013c32d62f16a296e`), `census-wide.cjs`
(md5 `c98410a19529c439adb0afbfb00026a2`) and `dirtable.cjs` (md5
`dda605c54745b4a60cc14c9a686e4eff`), byte-identical to the copies stages
10 to 24 used. A literal counts as a test title when its folded message
is argument 0 of a `describe` / `it` / `test` call, `.each` / `.skip` /
`.only` chains included. Everything else is an "other" string.

The worktree was cut from `origin/main` at `5a22eb5619`, the claim's
base and stage 24's landing. Both instruments read **371 messages / 392
ids in 84 files**, the seat's reading and stage 24's head reading.

| directory | files | messages / ids | titles | other |
|:--|--:|--:|--:|--:|
| `system/` | 34 | 154 / 167 | 128 / 138 | 26 / 29 |
| (files directly in `src/`) | 30 | 118 / 120 | 117 / 119 | 1 / 1 |
| `api/` (this PR: all 13 files) | 13 | 89 / 95 | 86 / 92 | 3 / 3 |
| `ui/` | 5 | 7 / 7 | 0 | 7 / 7 |
| `ai/` | 1 | 2 / 2 | 0 | 2 / 2 |
| `contracts/` | 1 | 1 / 1 | 0 | 1 / 1 |
| **total** | **84** | **371 / 392** | **331 / 349** | **40 / 43** |

The group reads **89 messages / 95 ids in 13 files**, the seat's figures
file for file:

| file (under `api/`) | messages / ids | titles | other |
|:--|--:|--:|--:|
| `plugin-rest-api.handler-status-retirement.test.ts` | 4 / 4 | 3 / 3 |
1 / 1 |
| `plugin-rest-api.schema-refs.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `plugin-rest-api.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `protocol.test.ts` | 46 / 50 | 46 / 50 | 0 |
| `registry-retirement.test.ts` | 2 / 2 | 1 / 1 | 1 / 1 |
| `rest-api-config-dead-keys-retirement.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `rest-server.test.ts` | 19 / 19 | 18 / 18 | 1 / 1 |
| `router.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `sortability.test.ts` | 3 / 4 | 3 / 4 | 0 |
| `storage.test.ts` | 2 / 2 | 2 / 2 | 0 |
| `validate-data.test.ts` | 3 / 3 | 3 / 3 | 0 |
| `websocket.test.ts` | 1 / 1 | 1 / 1 | 0 |
| `zod-issues-to-fields.test.ts` | 2 / 3 | 2 / 3 | 0 |
| **13 files** | **89 / 95** | **86 / 92** | **3 / 3** |

Five more test files sit in the same name range and carry no id
(`query-adapter.test.ts`, `realtime-shared.test.ts`, `realtime.test.ts`,
`retired-error-codes.test.ts`, `versioning.test.ts`). The three "other"
strings are expect failure messages, rewritten and declared to the
text-only tool: `plugin-rest-api.handler-status-retirement.test.ts:179`
and `rest-server.test.ts:768` (template literals) and
`registry-retirement.test.ts:89` (one leaf of a `+` chain).

- **Controls.** Lit: `ui/notification.test.ts` (1 id) and
`system/book.test.ts` (2 ids), outside the group, read the same at the
base and at the head. Dark: `protocol.test.ts` reads 0 at the head while
65 of its lines still carry a number, every one of them a comment.
Planted in a scratch tree: an id put into a `storage.test.ts` title
reads 1 / 1 (`title:it`), and an id put into a `sortability.test.ts`
comment reads 0.
- **A wider pattern** (any `#` plus digits) reads the same as the gate
pattern in all 13 files at the base, and 0 in all 13 at the head.
- **At the head:** 282 messages / 297 ids in 71 files. The 13 files read
0 / 0, `api/` leaves the table, and no other file moved.

## How the area was chosen

`api/` has no subdirectory, so it is taken in name-ordered file groups
near the ~100-id bound, the rule stages 20 to 24 used. Stage 24's cut
named this group at 95 ids, and this census reads 95, so no re-cut was
needed. `protocol.test.ts` (50 ids) fits one PR and one text-only proof,
so it is not split.

**Named for the next stages** (cut from the head census, 282 / 297):
- **`system/`**, 167 ids in 34 files (one of them in
`system/constants/`), two stages:
- **first group:** `auth-config.test.ts` through
`metadata-form-declared-rows.pin.test.ts`, 18 files, 91 messages / 97
ids (`i18n-resolver.test.ts` alone 53 / 56);
- **second group:** `metadata-form-zod-reconciliation.test.ts` through
`worker.test.ts`, 16 files, 63 / 70. Its first file carries 17 "other"
strings, its ledger `why` entries.
- The files directly in `src/`, 120, one stage.
- The needles: the three docblock needles, the kept
`ui/component-props-unknown-members.pin.test.ts:322` and stage 22's two.
One stage, with an at-tier review. The four colour literals stay, as
stage 21 decided.

## What each id became

- **10 literals (11 ids)** now state a decision in words.
- **12 literals (16 ids)** get their subject back in words, where the
number stood for a thing.
- **67 literals (68 ids)** drop a number the title already explains.

Every cited record was fetched with all its comments through REST, and
its decision was read from its ruling, ACCEPT and landing comments: a
keyword digest of every record, and full reads wherever the new words
carry a decision. 43 records are cited: 36 answer 200 and 7 answer 404.
Two more were read for context: objectstack-ai#14478, whose ruling B objectstack-ai#15677 executes,
and PR objectstack-ai#11426, objectstack-ai#11006's landing. The seven that answer 404 were read
from what landed, through the commits endpoint (this checkout is
shallow), each commit found through the CHANGELOG entry or the commit
list of `protocol.test.ts`:
- **objectstack-ai#6037**, from `18189983dd` (objectstack-ai#6474): `DataProtocol.validateData` asks
the write path for its verdict and persists nothing, objectstack-ai#4633 ruling D;
- **objectstack-ai#6239**, from `f549a0d4ad` (objectstack-ai#6526): `ViewProtocol`'s five
viewId-addressed methods and ten schemas are retired;
- **objectstack-ai#6361**, from `90bbf25107` (objectstack-ai#6866): the notification-list `cursor`
is tombstoned on both halves (maintainer ruling 2026-08-07, option A);
- **objectstack-ai#9740**, from `11b779e0f9` (objectstack-ai#9773):
`MetadataProtocol.getMetaItemLayered` is declared, and the dead
`'overlay'` `lockSource` arm is dropped;
- **objectstack-ai#9741**, from `2a29caa532` (objectstack-ai#9804): `previewDrafts` / `state` are
declared where the implementation enforces them, and `environmentId` is
recorded as transport-level. Its changeset
(`packages/spec/CHANGELOG.md:31798`) names it "maintainer ruling
2026-08-18", and `cccbe51bf7` cites "the objectstack-ai#9741 ruling";
- **objectstack-ai#11006**, from `cccbe51bf7` (objectstack-ai#11426): `publishMetaItem` is declared
as an optional member with `PublishMetaItemRequest` (maintainer ruling
2026-08-22, option B);
- **objectstack-ai#14691**, from `b3a63d32c9` (objectstack-ai#14868): the ten inert
`RestServerConfig` keys the liveness ledger recorded as `dead` are
retired.

**The same-id titles stage 24 listed in this group:**
- **`[objectstack-ai#5672]` x2** (`protocol.test.ts:508`, `:526`): objectstack-ai#5672's maintainer
ruling A (`5199159328`): one closed capability vocabulary, emitted in
full by both discovery producers, with an absent capability `enabled:
false` rather than a missing key. `:508` now reads "strips a capability
key outside the closed vocabulary". The old verb was "rejects", but the
body pins the opposite: the parse stays green and the key does not
survive it. `:526` now reads "… (ruled: an absent capability is
`enabled: false`, not a missing key)".
- **`(objectstack-ai#12038)` x5** (`:2575` to `:2686`): these five "declares the …
body" describes are the describe-only transcriptions that the five-part
ruling's implementation plan names (`5434804846`). None of them pins a
lettered sub-ruling, so no letter is named; the title already says the
decision, and only the number goes.
- **`(objectstack-ai#12038 1C)`** (`:2710`): now "GetPublishedMetaItemResponseSchema
stays opaque (ruled: no shape frozen against the current type
registry)", ruling 1C's own reason. Its children pin the `unknown` body.
- **`(objectstack-ai#19543, door ③)`** (`:2726`): door ③ is the AI-conversation list,
which the schema name already names, and "declares the next-page signal"
is that door's spec half (letter A, re-derivation `5825819437`). Only
the number and the door label go.
- **`(objectstack-ai#15677)`** in `plugin-rest-api.test.ts:694` and
`websocket.test.ts:712`: now "… durations carry their unit in the key
name", objectstack-ai#14478's ruling B (`5518649320`, population ruling `5548763981`),
which objectstack-ai#15677 executes for `api/`. In `router.test.ts:565` the title
already shows the rename (`RouteDefinition.timeout → timeoutMs`), so
only the number goes.

**Stated in words:**

| record | literal (under `api/`) | now reads | the decision |
|:--|:--|:--|:--|
| objectstack-ai#14478 via objectstack-ai#15677 | `plugin-rest-api.test.ts:694`,
`websocket.test.ts:712` | "… durations carry their unit in the key name"
| Ruling B: a `z.number()` duration key carries its unit in its name;
the old spellings are `retiredKey()` tombstones. |
| objectstack-ai#5672 | `protocol.test.ts:508` | "strips a capability key outside the
closed vocabulary" | Ruling A (2026-08-06): one closed vocabulary. |
| objectstack-ai#5672 | `protocol.test.ts:526` | "rejects a capability map that is
missing part of the vocabulary (ruled: an absent capability is `enabled:
false`, not a missing key)" | Ruling A: both producers emit the whole
vocabulary. |
| objectstack-ai#9406 | `protocol.test.ts:1313` | "probes is opaque BY DECLARATION
(ruled: modeled only once a consumer needs a field): …" | Maintainer
ruling 2026-08-18 (`5322875103`): `probes` gets a deliberately opaque
passthrough, upgraded to a modeled schema only when a consumer needs a
field of it. |
| objectstack-ai#9343 | `protocol.test.ts:1383` | "PublishPackageDraftsResponseSchema
published[].advisories (ruled: advisory findings ride each published
element)" | Maintainer ruling 2026-08-17 (`5321046016`): `advisories`
rides each `published[]` element, with no parallel top-level map. |
| objectstack-ai#9741 | `protocol.test.ts:1739` | "environmentId stays OUT of the
meta-read request shape — transport-level by decision, not omission" |
The 2026-08-18 ruling, as landed in `2a29caa532`: `environmentId` is the
transport-level multi-kernel routing key. |
| objectstack-ai#12038 | `protocol.test.ts:2710` | "GetPublishedMetaItemResponseSchema
stays opaque (ruled: no shape frozen against the current type registry)"
| Ruling 1C (`5434804846`): a thin envelope with the body opaque, no
union frozen against today's type registry. |
| objectstack-ai#6037 | `validate-data.test.ts:25` | "ValidateDataRequest — asks the
write path for its verdict instead of predicting it" | What landed in
`18189983dd`: the dry run stops predicting the write's verdict and asks
for it. |
| objectstack-ai#6037 | `validate-data.test.ts:57` | "ValidateDataResponse — the
verdict the write path would reach, persisting nothing" | The same
commit: `validateData` reports the write path's verdict on candidate
rows and persists nothing. |

**Subject back in words** (12 literals):
- "zero holders after objectstack-ai#13823" becomes "zero holders after its
retirement", and "[objectstack-ai#13823] ADR-0087 registration" becomes "handlerStatus
retirement — ADR-0087 registration", the form of the repo's other
retirement registration describes (objectstack-ai#13823 ruled remove, `5494755488`);
- "the routes wired in objectstack-ai#3899" becomes "the routes wired to the
request-schema gate", the gate the file's header names;
- "(objectstack-ai#13155 — carries objectstack-ai#5745 to the third verb)" becomes "(carries the
declared = returned discipline to the third verb)", the discipline objectstack-ai#7294
and objectstack-ai#13155 name objectstack-ai#5745 for;
- "(objectstack-ai#4717 — objectstack-ai#4463 D3 on the response)" and "(objectstack-ai#9176 — objectstack-ai#4463 D3 on the
publish door)" become "(advisory findings ride the 2xx response)" and
"(advisory findings ride the 2xx on the publish door too)": objectstack-ai#4463's D3
sends gating findings to 422 and lets advisory findings ride the 2xx;
- "the objectstack-ai#9612-gate class" becomes "the package-closure publish-gate
class": objectstack-ai#9612's gate judges a publish against the written package's
closure;
- "objectstack-ai#10235 the objectstack-ai#7865 anchor category" becomes "the unprovisioned
injected-anchor category", the platform anchors injected into an
external object whose storage the platform does not provision (objectstack-ai#7865,
ruling B);
- the two "pre-objectstack-ai#3689" storage shapes become shapes "from before the
shared success envelope";
- "the objectstack-ai#4052 non-repeat" becomes "the non-repeat of the retired
`validateOnly` dry-run flag";
- "every objectstack-ai#8055-shaped fixture" becomes "every malformed-flow-body
fixture".

**Dropped where already stated** (67 literals, 68 ids). A number goes
only where the title already says its decision. Examples: the two
`[objectstack-ai#13823]` describes and the twelve `[objectstack-ai#14691]` / `(objectstack-ai#14691)` retirement
titles ("REJECTS `patterns` with the retirement prescription — …", "the
tombstones reject one key each, not the config — …"); `[objectstack-ai#11983]` x3,
`[objectstack-ai#4579]` x2, `[objectstack-ai#4939]`, `[objectstack-ai#6361]`, `[objectstack-ai#20294]` and `objectstack-ai#3899 —`; the
`objectstack-ai#10235` prefixes on "resolveObjectSortability — the closed category
set" and "wire validity — …"; the five "transport-level by the objectstack-ai#9741
ruling" titles, which now read "transport-level by ruling"; the
parenthesized `(objectstack-ai#5745 — …)`, `(objectstack-ai#7294 — …)`, `(objectstack-ai#9406 — …)`, `(objectstack-ai#10524 —
…)` x2, `(objectstack-ai#9726 — …)`, `(objectstack-ai#9741 — …)` and `(objectstack-ai#4717 — …)` pairs, which keep
their words; and the tails `(objectstack-ai#6239)`, `(objectstack-ai#4286)`, `(objectstack-ai#9740)`, `(objectstack-ai#11006)`
x2, `(objectstack-ai#11678)` x3, `(objectstack-ai#9426)`, `(objectstack-ai#12005)` x3, `(objectstack-ai#11679)` x2, `(objectstack-ai#12004)`
x2, `(objectstack-ai#3718)`, `(objectstack-ai#4572)`, `(objectstack-ai#4579)`, `(objectstack-ai#20294)`, `(objectstack-ai#8124/objectstack-ai#8055)`, the
five `(objectstack-ai#12038)` and the `(objectstack-ai#4738, …)` aside in one expect message. The
404 numbers among them (objectstack-ai#6239, objectstack-ai#6361, objectstack-ai#9740, objectstack-ai#9741, objectstack-ai#11006, objectstack-ai#14691) go
only where the title already states what landed.

**No file is renamed.**

## Readers

- **Needles:** none. The three declared strings are assertion failure
messages (the second argument of `expect`), none is an expected value,
and no title or message in the group is matched against a source
docblock or another file's text. The one self-read in the group,
`rest-api-config-dead-keys-retirement.test.ts:519`, reads its own file
for the id-free describe title "tree-scoped absence", which this PR does
not touch.
- **Test-name filters:** none. No tracked script, workflow or package
config passes `-t` / `--testNamePattern` to vitest; the one vitest `-t`
hit is a README example under `packages/qa/dogfood` filtering its own
fixture.
- **Snapshots:** none. No `__snapshots__` directory is tracked under
`packages/spec`, and none of the 13 files calls a snapshot matcher.
- **Projects:** `rest-api-config-dead-keys-retirement.test.ts` is in the
`repo` project (`packages/spec/vitest.repo-tests.json:31`); the other 12
run in `local`. The base-versus-head run below takes both projects.
- **By substring:** every old literal, its id-bearing fragment and a
window around each id (270 needles) was searched with `git grep` at the
base, across the tracked tree outside its own file. No gate, doc,
filter, snapshot, QA checklist entry or `scripts/check-*.mjs` self-test
reads one. The 6 hits are sibling test titles: the two `(objectstack-ai#15677)`
describes in this group hit each other (both rewritten here),
`client/src/client.test.ts:1134` shares "query.distinct (objectstack-ai#4286)", and
`metadata-protocol/src/protocol.validate-data.test.ts:102` shares "the
objectstack-ai#4052 non-repeat".

## Text-only proof

Stage 10's scratch tool (`textonly10.cjs`, md5
`d5e4801dbb4329ab1984da91e92fc47c`) compares base and head file by file
on three legs:
1. **Skeleton:** the full AST, with string pieces masked. It must be
identical.
2. **Comments:** every comment, byte-equal.
3. **Strings:** each changed string leaf must sit in a test-call title
position or on a declared line, must carry a tracker id before, and must
carry no `#` plus digits after. This stage declares the three
expect-message lines named above.

- **Result:** 13 of 13 files SAME on all three legs, with the per-file
counts predicted in writing before any edit.
- **Totals:** 89 changed string leaves in 89 literals: 86 titles and 3
declared. The diff's `+` and `-` lines are exactly the 89 planned lines
as multisets, and every file keeps its line count.
- **Controls (14 of 14 as predicted on the first run, on scratch copies,
each anchor hit once):** identifier rename DIFF; numeric literal DIFF;
comment edit COMMENT DIFF; a non-title string given an id VIOLATION; a
rewritten title given a new id VIOLATION; a title that was id-free at
base edited VIOLATION; one title reverted to base SAME; an `it.each` row
given an id VIOLATION; an undeclared expect message changed VIOLATION; a
title re-split into a `+` chain DIFF; a declared expect message reverted
to base SAME; a declared template expect message given a new id
VIOLATION; a declared `+`-chain leaf given a new id VIOLATION; a
template-literal title given a new id VIOLATION.
- **Templates and tables:** no `.each` title and no `$name` placeholder
changes. The two template literals change only their text after the
`${…}` span.

**Test counts:** the 13 files were run at the base, in a separate base
worktree, and at the head, with `--project local --project repo`. Both
sides read 509 tests in 13 files, all passed, with the same count and
status sequence per file in 13 of 13. 250 full test names change, and
each changed name equals the base name with the planned replacements
applied: 0 mismatches. No full name repeats on either side, and no head
name carries `#` plus digits (250 base names did). `router.test.ts:565`
writes its arrow as a `→` escape; the plan's anchor there starts after
the escape, so the comparison tool, which reads escapes literally, met
none, and vitest prints "RouteDefinition.timeout → timeoutMs …" on both
sides.

## Changeset: `skip-changeset`

Measured, not assumed:
- `npm pack --dry-run` of `@objectstack/spec` lists 2068 files. 0 of the
13 touched files are in it, and no `*.test.ts` at all. The controls
`src/api/protocol.zod.ts`, `src/api/rest-server.zod.ts` and
`dist/index.mjs` are in it.
- In the built `dist/`, two new phrases and an old one each read in 0
files. The control `Unrecognized key` reads in 42.

So this PR publishes nothing, and no changeset is added.

## Verification (at `c63eba0adf`)

- `pnpm turbo run build` over all packages: 71 / 71, through the shared
verify lock (`VERDICT command-exit 0`).
- `@objectstack/spec`:
  - `vitest run --project local`: 619 files, 18480 passed, 1 todo.
- `typecheck`: exit 0, including `check:test-typecheck` (52 files / 246
errors / 135 pinned signatures held). Its program holds all 13 group
files, counted by path with `tsc --listFilesOnly -p tsconfig.test.json`.
- `check:generated`: all 15 generated artifacts up to date, against the
`dist/` the build above wrote.
- **Gates:** `dispatch-gates --commands` derived 79 families: stage 24's
80 without `check:error-code-casing`, whose named sources this diff does
not touch. All 79 exit 0. `--ran` reconciles: 79 derived, 79 run, 0
NOT-MEASURED, 0 UNRUN, every family with its exit code recorded. The
same 79 derive from `origin/main` `230e4944b0` with this diff applied.
The five roster families marked as sharing a directory with this diff
(`check:meta-url-spelling`, `check:spec-changes`,
`check:authz-resolver`, `check:error-code-casing`,
`check:filter-alias-parity`) each exit 0.
- **ESLint, a proven narrowing:** `--no-inline-config` over the 13 files
reads 0 errors and 0 warnings. The population comes from ESLint's own
config: 13 configured, 0 ignored. No file sets `parserOptions.project`
or `projectService`, so no untouched file's verdict can move.
- `check-governed-merges --test`: NOT governed, 178 changed lines (+89 /
-89).
- A control-byte scan over the 13 changed files finds none.

## `main` since the base

Re-fetched just before this PR opened, `origin/main` was six commits
past the base (`c9761cd2fb`: objectstack-ai#21966, objectstack-ai#21951, objectstack-ai#21963, objectstack-ai#21969, objectstack-ai#21965,
objectstack-ai#21962). They touch 28 files, none of the 13 and none under
`packages/spec/src/api/`, so `main` was not merged. The two
`packages/spec/src` files they change
(`data/datasource-credential-redaction.ts` and its test) read 0 / 0 in
the census at `c9761cd2fb`: the one id they add is a code comment. `git
merge-tree` onto `c9761cd2fb` is clean, and none of the 4 open PRs
touches any of the 13 files.

## Acceptance notes

- **Same-id test titles in this card's later stages** go with those
stages: `system/book.test.ts:413` (`(objectstack-ai#12038)`).
- **Same-id test titles in other packages** stay: 97 lines in 15
packages (`runtime` 25, `objectql` 13, `lint` 12, `metadata-protocol`
12, `rest` 12, `client` 8, `metadata-core` 4, `qa/dogfood` 2,
`service-automation` 2, `service-storage` 2, and one each in
`examples/app-crm`, `examples/app-showcase`, `driver-sql`,
`plugin-sharing` and `types`), each package's share under the objectstack-ai#20513
lane children.
- **Code comments with live ids** remain in these files and their
sources, among them the `* objectstack-ai#3899 —` header in
`plugin-rest-api.schema-refs.test.ts`, the `* objectstack-ai#8124 —` header in
`zod-issues-to-fields.test.ts`, the `// [objectstack-ai#5672] This fixture used to
lead with …` comment above `protocol.test.ts:508`, and the `/** [objectstack-ai#20294]
… */` docblock in `rest-api-config-dead-keys-retirement.test.ts`. Code
comments are not this card's share.

---

_Generated by [Claude
Code](https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants