fix(ci): Trim Features permissions and allow manual publish - #7
Merged
Merged
Conversation
Match the official features publish workflow permissions, and add workflow_dispatch so GHCR publish can be retested after package Actions access is granted.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Manual publishing must be restricted to main to prevent releases from unmerged branches.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates feature publishing permissions and enables manual reruns.
Changes:
- Removes unnecessary pull-request write access.
- Adds manual workflow dispatch.
| File | Description |
|---|---|
.github/workflows/features.yml |
Adjusts permissions and adds manual publishing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull-requests: writefrom the Features workflow;generate-docsis off and the officialdevcontainers/featuresrelease workflow only grantspackages: writeandcontents: write.workflow_dispatchso publish can be re-run after GHCR package Actions access is fixed, without another code push.Why Features still failed on main after #5
PR #5 correctly switched to
secrets.GITHUB_TOKENand granted job permissions. The post-merge run (36619966172) authenticated enough to read versions, then failed on upload with:Server did not provide instructions to authentiate! (Required: A 'WWW-Authenticate' Header)That matches GHCR packages that were first published with a PAT and never granted Actions access to this repository. Workflow YAML cannot fix that alone.
Required org/package step (before merge or right after)
For both packages:
ghcr.io/opencodeco/devcontainers/install-php-extensionsghcr.io/opencodeco/devcontainers(collection metadata)Package settings → Manage Actions access → add
opencodeco/devcontainerswith Write.Alternatively delete both packages so the next
GITHUB_TOKENpublish recreates them linked to this repo.Settings: https://github.com/orgs/opencodeco/packages/container/devcontainers%2Finstall-php-extensions/settings
Test plan
workflow_dispatchmainpublishes successfully