0.1.4: LIKE becomes ILIKE in the sqlite dialect - #2
Merged
Merged
Conversation
SQLite's LIKE is case-insensitive for ASCII; Postgres's is not, so every search an app wrote against SQLite silently lost its case-insensitive matches after a port (c0upons' coupon search returned a different half of its results). The rewriter now emits ILIKE (NOT LIKE -> NOT ILIKE, ESCAPE kept); string literals are untouched via the code mask. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite's
LIKEis case-insensitive (ASCII); Postgres's is not. Every search a SQLite app wrote withLIKEsilently lost its case-insensitive matches after a port: c0upons'/api/search?q=shoesreturned a different half of its 50 results on Postgres. The sqlite-dialect rewriter now emitsILIKE(NOT LIKE→NOT ILIKE,ESCAPEkept); string literals stay untouched through the code mask. README dialect table updated; unit test added (127/127).🤖 Generated with Claude Code