Repository navigation
Conversation
MbappeWU
marked this pull request as ready for review
October 5, 2026 23:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dynamic anchor selects an override nested inside
camera.json, subsequent#/$defs/sizereferences still resolve againstbase.json. The valid payload in python-jsonschema/jsonschema#1362 then raisesPointerToNowhere.Retain the matched dynamic resource URI without entering that resource's relative
$idagain. Record the actual caller in resolver history, rather than inferring it from the new target URI. This also distinguishes a foreignA#xreference whose initial target is replaced from a normal reference that first enters A and then follows#x. A laterB#ycorrectly selects B in the first path and A in the second. Nonconsecutive revisits remain in the evaluation path; repeated consecutive callers do not grow the scope.This follows Draft 2020-12 dynamic-reference URI replacement and dynamic scope. No public API, dependency, version or workflow changes are included. The anonymous-root registration handled by #367 remains separate; its private compatibility controls pass with this change. PR #423's empty-fragment lookup is also separate.
Validation:
$id, cross-directory relative IDs, follow-up pointers, and repeated scope history.PointerToNowhereon the exact original implementation.Local spelling cannot run without native Enchant. The unmodified original CI in the fork now passes all 44 jobs at
8dc7a35, including all three spelling jobs, style, typing, mypy, documentation builders and packaging. Every Python 3.13/3.14/3.14t/3.15 test job across Linux, macOS and Windows reports 508 passed; the additional coverage job also passes. All original commands and matrices are retained.The local full-history build produced
0.37.1.dev250+g8dc7a350b; the original shallow-checkout packaging job produced0.1.dev1+g8dc7a350b. These are validation snapshots. Tag-only publishing steps were skipped, and the temporarily enabled fork scheduler was disabled after the exact run completed.Upstream CI still requires maintainer approval. Upstream review, merge and release remain pending. No check or workflow was weakened.
AI assistance: OpenAI Codex and gpt-5.6-luna sub-agents prepared the implementation, regressions and review. These validations do not claim human review.