Conversation
FanWu-ai
marked this pull request as ready for review
October 5, 2026 05:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interval.__init__reconstructs the endpoints forprecise_diffwithout theirfoldvalues. This changes the UTC offset during a repeated DST hour, even thoughInterval.__new__preserves the fold for the total duration.For example, New York on 2024-11-03, 01:15 with
fold=0to 01:45 withfold=1, currently hastotal_seconds() == 5400but reports(hours, minutes) == (0, 30)andin_words() == "30 minutes".Pass each original fold to the corresponding reconstruction, matching
__new__. The interval then correctly reports one hour and thirty minutes. Tests cover both endpoints, signed/reversed/absolute intervals, and same-fold controls.Pull Request Check List
The untouched baseline passed the same checks before editing. Validation used Python 3.12.14, the real Rust extension, and locked dependencies. This is a fold-preservation fix; the separate same-wall-time datetime comparison issue discussed in #351 is outside its scope.
Independently reviewed and rechecked with both full backends, mypy, and every prek hook.
Prepared with OpenAI Codex assistance.