gh-158868: Reduce ASLR in the MSan CI job - #158872
Merged
Merged
Conversation
StanFromIreland
requested review from
AA-Turner,
JacobCoffee,
ezio-melotti,
hugovk,
itamaro and
webknjaz
as code owners
October 5, 2026 16:04
This was referenced Oct 5, 2026
vstinner
approved these changes
Oct 5, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. It seems correct to reuse the same configuration than then TSan job.
vstinner
enabled auto-merge (squash)
October 5, 2026 19:08
vstinner
disabled auto-merge
October 5, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported in #158868, rather than skipping the job.
To reproduce this locally:
We actually already do this for the TSan job, it seems we got unlucky on the PR that added MSan:
cpython/.github/workflows/reusable-san.yml
Line 49 in 508db6d
In the test, the mappings of the exec'd child sometimes land where MSan needs its shadow memory, so the MSan runtime disables ASLR and re-executes the process at startup, which fails because the child was started from a close-on-exec file descriptor.