Waveshare dsi - #7655
Open
EngineerWill wants to merge 2 commits into
Open
Waveshare dsi#7655EngineerWill wants to merge 2 commits into
EngineerWill wants to merge 2 commits into
Conversation
Add support for Waveshare automatic detection DSI panels which identify themselves at runtime via I2C registers. The driver reads screen type, rotation and refresh rate from registers 0xd0-0xd3 to select the appropriate display mode and DSI lane configuration. Supported configurations include 1200x1920 and 1920x1200 panels at both 30fps (2 lanes) and 60fps (4 lanes) refresh rates. Signed-off-by: Goodwill <646689853@qq.com>
Add the auto_detect overlay parameter to select the automatic detection panel compatible string (waveshare,automatic-detection-panel). This enables runtime panel detection via I2C for Waveshare DSI displays that support automatic identification. Signed-off-by: Goodwill <646689853@qq.com>
Contributor
|
I'm confused as this seems to be adding autodetection support, not reverting it. Have you pushed the correct branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the automatic panel detection previously added for the Waveshare 10.1inch DSI LCD (E) and replaces it with two explicit overlay parameters:
10_1_inchE_4lane— 1920x1200 @ 60fps, 4 DSI lanes10_1_inchE_2lane— 1920x1200 @ 30fps, 2 DSI lanesWhy
After the auto-detection support was merged, several people tested it and found the behaviour unfriendly for end customers:
This change removes the auto-detect code path (I2C reads, rotation handling and the portrait 1200x1920 modes) and keeps only the default landscape orientation. The panel variant is now chosen explicitly via the overlay parameter, and the driver writes the desired refresh rate to register 0xd0 accordingly.