Hold the image addresses and old links partners use, by test - #366
Merged
Merged
Conversation
Story 4 of specs/009-embeddable-diagram. AllianceGenome's gene pages show
reaction figures from the exporter by <img src>; PubChem hosts snapshots of
the diagram exporter's images and links to the Pathway Browser as
/PathwayBrowser/#/{stId}. Neither will change its links for us.
e2e/partner-links.spec.ts checks, against real ids from the local backend:
- /ContentService/exporter/reaction/{id}.svg and .png, and
/ContentService/exporter/diagram/{id}.svg, .png and .jpg, are each that
image type -- by their first bytes, not their status, since an image
address answering 200 with HTML is the failure this is for;
- /PathwayBrowser/#/{stId}, the form PubChem writes (legacy-links covered
#{stId} and #{dbId}, not this one), opens that pathway on its stable
address.
All six fail against wrong ids: the exporters answer 400, and the link
opens no pathway. The exporters go through the ContentService proxy to
Java, not the render service, so they replay in CI with no skips; the
pathway is a small one, so its images record in ~450 KB.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story 4 of
specs/009-embeddable-diagram. Other sites already use these addresses, and they won't change their links for us:<img src>./PathwayBrowser/#/{stId}.e2e/partner-links.spec.tschecks these against real ids from the local backend: reaction R-HSA-69891 and pathway R-HSA-2206280./ContentService/exporter/reaction/{id}.svgand.png, and/ContentService/exporter/diagram/{id}.svg,.pngand.jpg, are each that image type. They are checked by their first bytes, not their status, because an image address answering 200 with HTML is exactly the failure this is for./PathwayBrowser/#/{stId}opens that pathway on its stable address.legacy-links.spec.tscovered#{stId}and#{dbId}, not this form.All six fail against wrong ids: the exporters answer 400, and the link opens no pathway.
The exporters go through the ContentService proxy to Java, not the render service, so they replay in CI with no skips. The pathway was chosen small so that its images record in about 450 KB; the recordings add 1.2 MB in total.
🤖 Generated with Claude Code