Conversation
Gunzip errors from malformed or empty gzip payloads were uncaught, so a single bad Content-Encoding: gzip request could take down the process. Surface them as InvalidContentError instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
A request with
Content-Encoding: gzipand an empty or malformed body currently kills the process.bodyReaderpipes the payload throughzlib.createGunzip()with noerrorlistener, so zlib'sunexpected end of file/ invalid-header errors become uncaught. DefaulthandleUncaughtExceptionsisfalse, so one bad request takes the server down.Changes
Listen for gunzip
errorand pass it tonext()asInvalidContentError(HTTP 400), matching howjsonBodyParserhandles malformed JSON.Regression coverage in
test/plugins/bodyReader.test.js:Content-Encoding: gzipand no body (the Process crashes on invalid gzip body from client #1975 repro) returns 400 instead of crashing, and a follow-up request still succeedsVerified
eslinton the changed files and the plugin mocha suite (211 passing).