Pass the reported job row to error handlers - #1401
Merged
Merged
Conversation
bgentry
force-pushed
the
bg/fix-multi-job-error-handler
branch
from
September 28, 2026 02:12
3e748cd to
d4aacd3
Compare
brandur
approved these changes
Sep 28, 2026
bgentry
force-pushed
the
bg/fix-multi-job-error-handler
branch
from
September 28, 2026 15:36
d4aacd3 to
737f8ab
Compare
When an execution reports errors for several jobs, each handler invocation receives the executor's original row. Logging and retry decisions for later jobs can therefore use the wrong ID, args, or attempt. Pass the row being reported to both error and panic handlers. Cover an execution that reports errors for several jobs and verify that each handler invocation receives its own row.
bgentry
force-pushed
the
bg/fix-multi-job-error-handler
branch
from
September 28, 2026 15:44
737f8ab to
36d797e
Compare
bgentry
marked this pull request as ready for review
September 28, 2026 15:48
bgentry
enabled auto-merge (squash)
September 28, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an execution reports errors for several jobs, every error handler invocation currently receives the executor's original job row. Pass the row being reported to the error and panic handlers so each invocation sees the correct job ID, args, and attempt.
Add a regression case that reports errors for several jobs and verifies that each handler call receives that job's row.