Drop breaking change banner from release message - #1414
Merged
Merged
Conversation
The patch in #1404 contains a minor breaking change in which using `UniqueOpts{ExcludeKind: true}` with no other options now returns an error, and we'd put in a breaking change banner right at the top of the release. This is a breaking change, but it's quite a minor one, and one that I don't think is likely to affect many users, if anybody. If it does affect someone, it's the "good" kind of breaking change in that it returns an error immediately instead of having some new unintended side effect. I don't think this quite meets the bar for a call out right at the top of the release, so here I'm demoting it so that we mention the breaking change, but inline with the changelog entry for #1404 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch in #1404 contains a minor breaking change in which using
UniqueOpts{ExcludeKind: true}with no other options now returns anerror, and we'd put in a breaking change banner right at the top of the
release.
This is a breaking change, but it's quite a minor one, and one that I
don't think is likely to affect many users, if anybody. If it does
affect someone, it's the "good" kind of breaking change in that it
returns an error immediately instead of having some new unintended side
effect. I don't think this quite meets the bar for a call out right at
the top of the release, so here I'm demoting it so that we mention the
breaking change, but inline with the changelog entry for #1404 instead.