Repository navigation
Report the attempted depth in generator nesting errors - #1097
Merged
Merged
Conversation
byroot
reviewed
Oct 6, 2026
ydah
force-pushed
the
fix-generator-nesting-error-depth
branch
from
October 6, 2026 12:08
63d31f6 to
ecdbaeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C and Java generators decrement the depth before reporting it in NestingError, making the reported depth one too small.
Report the attempted depth while preserving depth restoration, same as TruffleRuby. Test arrays, hashes, nonzero initial depths, and State reuse after an error.