demo: keep every random case in the String#trim demo - #342
Merged
Merged
Conversation
The demo stored its 100 random cases in a Hash keyed by the input, so a repeated random input silently replaced an earlier case and the QED assertion count varied between runs. An array of pairs keeps them all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "random placement" section of
demo/core/string/trim.mdstored its 100 random cases in a Hash keyed by the generated input. When two inputs came out the same, the later one replaced the earlier, sorake qedsometimes reported 729 assertions instead of 730.Storing the cases as an array of
[input, expected]pairs keeps all 100. The demo now reports 111/111 assertions on every run (checked three runs).🤖 Generated with Claude Code
https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW
Generated by Claude Code