Fix slicing converted Java lists - #94
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Slicing the list-like result of
to_python(java_list)currently passes a Python slice to Java's integer-onlyList.get, raising TypeError. Handle slices using their normalized indices and the existing per-element conversion path, returning a Python list. This supports omitted and negative bounds, negative steps, empty slices, and the usual ValueError for a zero step without changing integer indexing.Added JVM-backed regression tests for those cases, empty lists, and Java objects without a Python converter. Nine initial regression cases fail before the fix. All 45 conversion, array, basic, type, and inspection tests pass on Windows/Python 3.13/Java 26; Ruff lint and formatting pass. Those focused tests use standard Java classes with the unrelated Maven endpoints cleared. The full suite did not finish during local verification and was interrupted while resolving the larger ImageJ dependency set; its result remains unverified.
Prepared with Codex assistance.