Skip to content

Use IsCliticRule to allow clitics to apply to templates - #529

Draft
jtmaxwell3 wants to merge 5 commits into
masterfrom
add-IsCliticRule
Draft

jtmaxwell3 wants to merge 5 commits into
masterfrom
add-IsCliticRule

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

This uses IsCliticRule to allow clitics to apply to templates instead of clearing FinalTemplateState and IsLastAppliedRuleFinal at the end of each stratum (since clitics are in a different stratum). This is necessary now that FieldWorks lets users specify the strata for performance reasons. Non-final templates and partial parses are only checked on the last stratum.

Damien agreed to something like this in an earlier discussion.

I also had to make changes at line 67 of SynthesisAffixTemplateRule and line 70 of SynthesisStratumRule to make this work.


This change is Reviewable

@jtmaxwell3
jtmaxwell3 marked this pull request as draft October 1, 2026 16:06
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.33%. Comparing base (c7146cd) to head (2595fe6).

Files with missing lines Patch % Lines
...orphology.HermitCrab/MorphemicMorphologicalRule.cs 66.66% 1 Missing and 1 partial ⚠️
...hine.Morphology.HermitCrab/SynthesisStratumRule.cs 77.77% 1 Missing and 1 partial ⚠️
...rphology.HermitCrab/SynthesisAffixTemplatesRule.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   74.34%   74.33%   -0.01%     
==========================================
  Files         456      456              
  Lines       38261    38274      +13     
  Branches     5242     5245       +3     
==========================================
+ Hits        28445    28452       +7     
- Misses       8666     8669       +3     
- Partials     1150     1153       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants