Use IsCliticRule to allow clitics to apply to templates - #529
Draft
jtmaxwell3 wants to merge 5 commits into
Draft
jtmaxwell3 wants to merge 5 commits into
jtmaxwell3 wants to merge 5 commits into
Conversation
jtmaxwell3
marked this pull request as draft
October 1, 2026 16:06
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 74.34% 74.33% -0.01%
==========================================
Files 456 456
Lines 38261 38274 +13
Branches 5242 5245 +3
==========================================
+ Hits 28445 28452 +7
- Misses 8666 8669 +3
- Partials 1150 1153 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses IsCliticRule to allow clitics to apply to templates instead of clearing FinalTemplateState and IsLastAppliedRuleFinal at the end of each stratum (since clitics are in a different stratum). This is necessary now that FieldWorks lets users specify the strata for performance reasons. Non-final templates and partial parses are only checked on the last stratum.
Damien agreed to something like this in an earlier discussion.
I also had to make changes at line 67 of SynthesisAffixTemplateRule and line 70 of SynthesisStratumRule to make this work.
This change is