Reduce redundant Microsoft Graph requests during Conditional Access collection - #195
Open
0xDarknightHacks wants to merge 1 commit into
Open
0xDarknightHacks wants to merge 1 commit into
0xDarknightHacks wants to merge 1 commit into
Conversation
Contributor
Pull request targets
|
Up to standards ✅🟢 Issues
|
0xDarknightHacks
force-pushed
the
perf/conditional-access-graph-requests
branch
from
September 26, 2026 21:03
027fa51 to
bcfbdab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While profiling Monkey365 during Microsoft 365 security assessments, I noticed redundant Microsoft Graph requests being made during Conditional Access collection.
This PR focuses only on reducing those unnecessary requests. The goal is to avoid retrieving data that has already been collected or is already available during the same assessment, while preserving the existing Conditional Access collection behavior and output.
This change originally came from performance work I was doing in my own fork of Monkey365. I am submitting it separately so the optimization can be reviewed independently rather than proposing the broader set of performance changes at once.
Description
This PR removes redundant Microsoft Graph requests from the Conditional Access collection path and reuses the data already available to the collector where applicable.
The scope is intentionally narrow:
This is a performance optimization rather than a fix for an existing reported issue, so there is no associated issue number.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.