Skip to content

feat(valkey): add Key Value Store to valkey descriptions - #1588

Merged
GokceGK merged 4 commits into
mainfrom
feat/STACKITTPR-845-update-valkey-docs
Sep 30, 2026
Merged

GokceGK merged 4 commits into
mainfrom
feat/STACKITTPR-845-update-valkey-docs

Conversation

@GokceGK

@GokceGK GokceGK commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

relates to STACKITTPR-845

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK
GokceGK requested a review from a team as a code owner September 8, 2026 14:07
Comment thread internal/cmd/valkey/credentials/create/create.go Outdated
Comment thread internal/cmd/valkey/credentials/create/create.go Outdated
Comment thread internal/cmd/redis/redis.go Outdated
@GokceGK
GokceGK requested a review from rubenhoenle September 9, 2026 10:58
@github-actions

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale label Sep 24, 2026
@GokceGK GokceGK removed the Stale label Sep 28, 2026
@GokceGK

GokceGK commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

not stale

rubenhoenle
rubenhoenle previously approved these changes Sep 29, 2026
@GokceGK
GokceGK force-pushed the feat/STACKITTPR-845-update-valkey-docs branch from 817c7b5 to a1db380 Compare September 29, 2026 14:50
@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 7 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/config/set 91.28% (+0.18%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/config/unset 35.04% (-0.04%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/clone 44.44% (+1.59%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/postgresflex/instance/create 51.09% (+2.95%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/kubeconfig/login 41.20% (+30.02%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/valkey 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/create 56.45% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/delete 35.90% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/describe 69.77% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/list 57.14% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/create 62.77% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/delete 25.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/describe 74.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/list 56.52% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/update 61.46% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/plans 53.85% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/auth 57.53% (+1.32%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/config 70.53% (+0.10%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/utils 57.25% (+4.31%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/redis/redis.go 0.00% (ø) 6 0 6
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/create/create.go 56.45% (ø) 62 35 27
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/credentials.go 0.00% (ø) 7 0 7
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/delete/delete.go 35.90% (ø) 39 14 25
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/describe/describe.go 69.77% (ø) 43 30 13
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/credentials/list/list.go 57.14% (ø) 49 28 21
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/create/create.go 62.77% (ø) 94 59 35
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/delete/delete.go 25.00% (ø) 40 10 30
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/describe/describe.go 74.00% (ø) 50 37 13
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/instance.go 0.00% (ø) 8 0 8
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/list/list.go 56.52% (ø) 46 26 20
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/instance/update/update.go 61.46% (ø) 96 59 37
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/plans/plans.go 53.85% (ø) 52 28 24
github.com/stackitcloud/stackit-cli/internal/cmd/valkey/valkey.go 0.00% (ø) 6 0 6

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@GokceGK
GokceGK merged commit 8db08c7 into main Sep 30, 2026
4 checks passed
@GokceGK
GokceGK deleted the feat/STACKITTPR-845-update-valkey-docs branch September 30, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants