Repository navigation
[6.x] Improve list of CP's formatting locales - #15589
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone reached out via support saying their preferred formatting locale is missing. The currently available locales only listed the Control Panel's translation languages, so regional variants like
fr-CHwere missing. It's actually possible to type in any value and save, not just the ones offered in the list. However, nothing in the UI said so.This PR:
de-AT,en-GB,es-419(TIL that's Latin American Spanish's code),fr-CA,fr-CH, andit-CH. Each one formats dates or numbers differently from its base language (e.g.fr-CH→06.01.2026,it-CH→1’234’567.89(some wild thousands separator)).navigator.languages) to the options, so their own locale shows up without being added to the list explicitly.Browsers don't provide a way to list every locale they support, so the list stays curated. Anything else can still be typed in, and the browser checks it as before.