Skip to content

fix[backend](execution): masked secret variables on execution history #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSanchez-bit merged 4 commits into from
Sep 28, 2026
Merged

fix[backend](execution): masked secret variables on execution history #2767

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd1a0b6
fix[backend](execution): masked secret variables on execution history
AlexSanchez-bit Sep 28, 2026
1aeb976
Merge branch 'release/v12.0.0' into backlog/v12_masked_secret_vars
AlexSanchez-bit Sep 28, 2026
9509fd7
fix[backend](command): added start manual execution mask
AlexSanchez-bit Sep 28, 2026
399c1b5
fix[backend](command): added soar flow execution variable masking
AlexSanchez-bit Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions backend/modules/soar/usecase/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ func (u *executionUsecase) HandleMatch(ctx context.Context, req dto.MatchRequest
_ = catcher.Error("soar: command interpolation failed", ierr, map[string]any{"rule": req.RulePath, "root": rootID})
continue
}

masked_command,cerr := u.vars.MaskSecrets(ctx,command)
if cerr != nil {
_ = catcher.Error("soar: command variable masking failed", cerr,map[string]any{"rule": req.RulePath, "root": rootID})
}


exec := &domain.SoarExecution{
TenantID: tenantUUID,
Origin: domain.ExecutionOriginFlow,
Expand All @@ -105,7 +112,7 @@ func (u *executionUsecase) HandleMatch(ctx context.Context, req dto.MatchRequest
Executor: node.Executor,
Params: params,
Context: json.RawMessage(bag),
Command: command,
Command: masked_command,
Shell: node.Shell,
Agent: agent,
Status: domain.ExecutionStatusPending,
Expand Down Expand Up @@ -164,6 +171,7 @@ func (u *executionUsecase) List(ctx context.Context, f dto.ExecutionFilters) (*d
items := make([]dto.ExecutionResponse, len(executions))
for i, e := range executions {
CommandSummary(ctx, u.vars, &e)

items[i] = dto.ExecutionResponse{
ID: e.ID,
Origin: e.Origin,
Expand All @@ -190,11 +198,17 @@ func (u *executionUsecase) List(ctx context.Context, f dto.ExecutionFilters) (*d
}

func (u *executionUsecase) StartManual(ctx context.Context, agent, command, triggeredBy string) (uuid.UUID, error) {

masked_command,cerr := u.vars.MaskSecrets(ctx,command)
if cerr != nil {
_ = catcher.Error("soar: command variable masking failed", cerr,map[string]any{})
}

e, err := u.repo.Create(ctx, &domain.SoarExecution{
Origin: domain.ExecutionOriginManual,
TriggeredBy: triggeredBy,
Agent: agent,
Command: command,
Command: masked_command,
Executor: "shell",
Kind: domain.NodeKindExecutor,
NodeID: "manual",
Expand Down
Loading