Skip to content

Handle mb_strlen() failure in safe_strlen() #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Oct 6, 2026
Merged

Handle mb_strlen() failure in safe_strlen() #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions lib/cli/cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,20 @@ function safe_strlen( $str, $encoding = false ) {
$encoding = mb_detect_encoding( $str, null, true /*strict*/ );
}
$length = is_string( $encoding ) ? mb_strlen( $str, $encoding ) : mb_strlen( $str ); // mbstring funcs can fail if given `$encoding` arg that evals to false.
if ( 'UTF-8' === $encoding ) {
// Subtract combining characters.
$m_regex = get_unicode_regexs( 'm' );
assert( is_string( $m_regex ) );
$length -= preg_match_all( $m_regex, $str, $dummy /*needed for PHP 5.3*/ );
}
if ( ! $test_safe_strlen || ( $test_safe_strlen & 4 ) ) {
return $length;
// `mb_strlen()` returns false on failure in PHP < 8, in which case fall back to `strlen()` (which also covers the empty string).
if ( $length ) {
if ( 'UTF-8' === $encoding ) {
// Subtract combining characters.
$m_regex = get_unicode_regexs( 'm' );
assert( is_string( $m_regex ) );
$combining_count = preg_match_all( $m_regex, $str, $dummy /*needed for PHP 5.3*/ );
if ( false !== $combining_count ) {
$length -= $combining_count;
}
}
if ( ! $test_safe_strlen || ( $test_safe_strlen & 4 ) ) {
return $length;
}
}
}
return strlen( $str );
Expand Down
Loading