Fix JAR lookup in integration test and pin hadoop-common to 3.4.x - #764
Merged
Merged
Conversation
- test-jar-integration.sh could pick sbt 2's meta-build jar (snappy-java-build_sbt2_3-*.jar); only look in the project's output directory - Hadoop 3.5+ requires Java 17, so keep Scala Steward on 3.4.x Co-Authored-By: Treasure Work <291137728+treasure-work@users.noreply.github.com>
Co-Authored-By: Treasure Work <291137728+treasure-work@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-jar-integration.sh. Since Upgrade to sbt 2.0.10 and Scala 3.9.0 #759, the script found the jar withfind target -name 'snappy-java-*.jar'. That also matches sbt 2's build-definition jar (target/out/jvm/scala-3.8.4/snappy-java-build/snappy-java-build_sbt2_3-0.1.0-SNAPSHOT.jar), andls -tthen picked whichever was newer. The JDK 17–25 jobs on Update hadoop-common to 3.5.0 #761 failed withpackage org.xerial.snappy does not existbecause of this. The script now only looks under*/snappy-java/.hadoop-commonto 3.4.x for Scala Steward (new.scala-steward.conf). Hadoop 3.5.0 is compiled for Java 17 (class file 61), soSnappyHadoopCompatibleOutputStreamTestfails on JDK 8/11 withUnsupportedClassVersionError. Hadoop is a test-only dependency, so 3.4.x is enough. Steward will still offer 3.4.x patch updates. This replaces Update hadoop-common to 3.5.0 #761.script/**changes. CI usesscript/test-jar-integration.sh, but changes to it skipped the test jobs. Skipped matrix jobs report astest jdk${{ matrix.version }}instead of the requiredtest jdk8etc., so such PRs could never satisfy branch protection.Test plan
TEST_JAVA_HOME=<zulu 8> ./script/test-jar-integration.shpickstarget/out/jvm/u/snappy-java/snappy-java-*.jarand passes💎 Generated with Treasure Work