Conversation
[expected.un.eq] mandates x.error() == y.error() be well-formed and its result be convertible to bool. Enforce it with a static_assert in the body so malformed comparisons get a clear diagnostic instead of obscure hard errors. Also fix the noexcept specifier: noexcept(lhs.error() == rhs.error()) only inspected the comparison, ignoring the implicit result-to-bool conversion performed by the return statement, so the operator could be declared noexcept yet terminate at runtime on a throwing conversion. Use expected_detail::is_nothrow_equality_result_convertible_to_bool_v, which covers the whole expression and matches the convention used by every other equality operator in this header. Signed-off-by: Yuming He <ComixHe1895@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[expected.un.eq] mandates x.error() == y.error() be well-formed and its result be convertible to bool. Enforce it with a static_assert in the body so malformed comparisons get a clear diagnostic instead of obscure hard errors.
Also fix the noexcept specifier: noexcept(lhs.error() == rhs.error()) only inspected the comparison, ignoring the implicit result-to-bool conversion performed by the return statement, so the operator could be declared noexcept yet terminate at runtime on a throwing conversion.
Use expected_detail::is_nothrow_equality_result_convertible_to_bool_v, which covers the whole expression and matches the convention used by every other equality operator in this header.