Conversation
This was referenced Aug 31, 2026
Contributor
|
@hCoureau Could you fix the conflict? |
Contributor
Author
|
Resolved the merge conflicts with current Validation: 1,026 tests passed, 92 snapshots passed, all pre-commit hooks passed, and sdist/wheel builds passed. GitHub CI was triggered for the new head. Required maintainer approval still applies. The existing stacked dependencies on #936 and #937 still apply; this update does not bypass their review or merge order. Conflict resolution and validation performed with OpenAI Codex assistance. |
This was referenced Sep 11, 2026
# Conflicts: # roborock/devices/traits/b01/q10/maps.py # tests/devices/traits/b01/q10/test_clean_history.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q10 map packets contain obstacle positions without validated type or photo metadata. This parses their bounded point tables and exposes calibrated, position-only markers on live, saved, and clean-history maps.
Implementation
Q10Obstaclevalues through the existing map traits, returning copies of their lists.Dependencies
Depends on #937. Parser support from #936 and the model-conformance fix in #965 are merged. Upstream
mainthroughb3a98b9(7.12.0) is integrated.Allen’s follow-up feedback on merged #936 is addressed by separate clean-record and saved-map decoder tests, with no conditional assertions.
Validation and limits
Validation of
f157a8c:uv run pytest -qon Python 3.13: 1,452 passed, 53 xfailed, 92 snapshots passed.uv buildpassed for both wheel and sdist.No physical-device run was performed for this revision.
Tests cover bounded/truncated tables, archive data, marker placement, and drawable configuration. Earlier physical Q10 S5 validation exercised position-only obstacles; those hardware checks have not been rerun for this revision.
Obstacle types, confidence, and photo identifiers are not inferred. Rendering requires usable map-header calibration. Archive requests inherit the bounded lifecycle from #937, including its clean-history ambiguity barrier and same-map freshness limitation.
No private map captures or account data are included. Related: #767.