Repository navigation
Conversation
xerial
enabled auto-merge (squash)
October 3, 2026 22:20
sbt 2 requires JDK 17+ to run, so CI now runs sbt on JDK 21 and forks tests on the matrix JDK (8, 11, 17, 21, 25) via TEST_JAVA_HOME. Co-Authored-By: Treasure Work <291137728+treasure-work@users.noreply.github.com>
…ses dynamically - Set TEST_JAVA_HOME on Test / forkOptions instead of Test / javaHome, which also made javac run on JDK 8 and fail on --release - SnappyLoaderTest hard-coded target/classes, which sbt 2 no longer uses Co-Authored-By: Treasure Work <291137728+treasure-work@users.noreply.github.com>
Co-Authored-By: Treasure Work <291137728+treasure-work@users.noreply.github.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.sbtfixes for sbt 2 and Scala 3:url(...)→uri(...), and the infixexclude→.exclude(...).test jdkNjob installs JDK 21 for sbt. Tests run in a forked JVM on the matrix JDK via the newTEST_JAVA_HOMEvariable, which is applied toTest / forkOptions. SettingTest / javaHomeinstead would also makejavacrun on JDK 8, which fails on--release. The JAR integration test also usesTEST_JAVA_HOME.testFullin CI: sbt 2'stestskips tests that passed in a cached previous run, and switchingTEST_JAVA_HOMEdoesn't invalidate that cache. CI caches~/.cache, so it now runstestFull.SnappyLoaderTest: it hard-codedtarget/classes, which sbt 2 no longer uses. It now gets the class path fromSnappy's code source.target/out/jvm/u/snappy-java/instead oftarget/, so the musl job andtest-jar-integration.shnow find the classes directory and jar withfind.Verification
main:./sbt testFullon JDK 25: 139 passed, 1 ignoredTEST_JAVA_HOME=<zulu 8> ./sbt testFullwith sbt on JDK 25: 139 passed, 1 ignoredscript/test-jar-integration.shwithTEST_JAVA_HOME=<zulu 8>: passedpublishSignedandsonaReleaseare still available, andpublishToresolves as beforeNotes
💎 Generated with Treasure Work